You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/16 16:02:10 UTC
[GitHub] [beam] Naireen opened a new pull request, #21915: convert windmill min timestamp to beam min timestamp
Naireen opened a new pull request, #21915:
URL: https://github.com/apache/beam/pull/21915
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1157845657
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Naireen commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
Naireen commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1171569675
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1157845651
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Naireen commented on a diff in pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
Naireen commented on code in PR #21915:
URL: https://github.com/apache/beam/pull/21915#discussion_r924989506
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java:
##########
@@ -351,12 +356,25 @@ public static TimerData windmillTimerToTimerData(
// For backwards compatibility, handle the case were the output timestamp isn't present.
Instant outputTimestamp = timestamp;
+ System.out.println("coumputed timestamp: " + String.valueOf(timestamp));
+ System.out.println("coumputed outputTimestamp: " + String.valueOf(outputTimestamp));
+
if ((outputTimestampStart < tag.size())) {
try {
outputTimestamp =
new Instant(
VarInt.decodeLong(
tag.substring(outputTimestampStart, outputTimestampEnd).newInput()));
+ System.out.println(
+ "parsed string"
+ + String.valueOf(
+ tag.substring(outputTimestampStart, outputTimestampEnd).newInput()));
+ if (outputTimestamp.isBefore(BoundedWindow.TIMESTAMP_MIN_VALUE)) {
Review Comment:
removed this logic
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimeUtils.java:
##########
@@ -42,13 +42,23 @@ public class WindmillTimeUtils {
* round timestamps down and output watermarks up.
*/
public static Instant windmillToHarnessTimestamp(long timestampUs) {
+ System.out.println("check if need to bound timestamp: " + String.valueOf(timestampUs));
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
scwhittle commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1196060871
LGTM, is there a github issue that should be referenced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a diff in pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
robertwb commented on code in PR #21915:
URL: https://github.com/apache/beam/pull/21915#discussion_r922463977
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimeUtils.java:
##########
@@ -42,13 +42,23 @@ public class WindmillTimeUtils {
* round timestamps down and output watermarks up.
*/
public static Instant windmillToHarnessTimestamp(long timestampUs) {
+ System.out.println("check if need to bound timestamp: " + String.valueOf(timestampUs));
Review Comment:
Remove these debugging statements?
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java:
##########
@@ -351,12 +356,25 @@ public static TimerData windmillTimerToTimerData(
// For backwards compatibility, handle the case were the output timestamp isn't present.
Instant outputTimestamp = timestamp;
+ System.out.println("coumputed timestamp: " + String.valueOf(timestamp));
+ System.out.println("coumputed outputTimestamp: " + String.valueOf(outputTimestamp));
+
if ((outputTimestampStart < tag.size())) {
try {
outputTimestamp =
new Instant(
VarInt.decodeLong(
tag.substring(outputTimestampStart, outputTimestampEnd).newInput()));
+ System.out.println(
+ "parsed string"
+ + String.valueOf(
+ tag.substring(outputTimestampStart, outputTimestampEnd).newInput()));
+ if (outputTimestamp.isBefore(BoundedWindow.TIMESTAMP_MIN_VALUE)) {
Review Comment:
Can we re-use the code above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1157845652
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
aaltay merged PR #21915:
URL: https://github.com/apache/beam/pull/21915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Naireen commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
Naireen commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1161778756
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1157845658
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Naireen commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
Naireen commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1190497859
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1196068792
Merging this. Tests are passing and @scwhittle reviewed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1157845655
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Naireen commented on pull request #21915: convert windmill min timestamp to beam min timestamp
Posted by GitBox <gi...@apache.org>.
Naireen commented on PR #21915:
URL: https://github.com/apache/beam/pull/21915#issuecomment-1158028913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org