You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekagarwal87 (via GitHub)" <gi...@apache.org> on 2023/02/15 17:17:29 UTC
[GitHub] [druid] abhishekagarwal87 opened a new pull request, #13782: Use K3S instead of minikube for integration tests
abhishekagarwal87 opened a new pull request, #13782:
URL: https://github.com/apache/druid/pull/13782
We are seeing failures on GHA while using minikube so trying out K3S. K3S is also lightweight. The PR is co-authored by @tejaswini-imply
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13782: Use K3S instead of minikube for integration tests
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #13782:
URL: https://github.com/apache/druid/pull/13782#discussion_r1108031204
##########
.github/workflows/standard-its.yml:
##########
@@ -100,6 +100,54 @@ jobs:
override_config_path: ./environment-configs/test-groups/custom-coordinator-duties
group: custom coordinator duties
+ integration-k8s-leadership-tests:
+ name: (Compile=openjdk8, Run=openjdk8, Cluster Build On K8s) ITNestedQueryPushDownTest integration test
+ runs-on: ubuntu-22.04
+ env:
+ MVN: mvn --no-snapshot-updates
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
+ CONFIG_FILE: k8s_run_config_file.json
+ IT_TEST: -Dit.test=ITNestedQueryPushDownTest
+ POD_NAME: int-test
+ POD_NAMESPACE: default
+ BUILD_DRUID_CLUSTER: true
+ steps:
+ - name: Checkout branch
+ uses: actions/checkout@v3
+
+ - name: Setup java
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: 8
+
+ - name: Restore Maven repository
+ id: maven-restore
+ uses: actions/cache/restore@v3
+ with:
+ path: ~/.m2/repository
+ key: maven-${{ runner.os }}-8-${{ github.sha }}
+
+ - name: Maven build
+ if: steps.maven-restore.outputs.cache-hit != 'true'
+ run: |
+ ./it.sh ci
+
+ - name: Run IT
+ id: test
+ run: |
+ # Debug echo
+ echo "MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}"
+ MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}
Review Comment:
makes sense. will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #13782: Use K3S instead of minikube for integration tests
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #13782:
URL: https://github.com/apache/druid/pull/13782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tejaswini-imply commented on a diff in pull request #13782: Use K3S instead of minikube for integration tests
Posted by "tejaswini-imply (via GitHub)" <gi...@apache.org>.
tejaswini-imply commented on code in PR #13782:
URL: https://github.com/apache/druid/pull/13782#discussion_r1108110949
##########
integration-tests/script/setup_k8s_cluster.sh:
##########
@@ -16,19 +16,13 @@
set -e
-# Set Necessary ENV
-export CHANGE_MINIKUBE_NONE_USER=true
-export MINIKUBE_WANTUPDATENOTIFICATION=false
-export MINIKUBE_WANTREPORTERRORPROMPT=false
-export MINIKUBE_HOME=$HOME
+export INSTALL_K3S_VERSION=v1.21.14+k3s1
export KUBECONFIG=$HOME/.kube/config
-sudo apt install -y conntrack
-
-# Lacunch K8S cluster
+# Launch K8S cluster
curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/v1.18.1/bin/linux/amd64/kubectl && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
-curl -Lo minikube https://storage.googleapis.com/minikube/releases/v1.8.1/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/
-sudo /usr/local/bin/minikube start --profile=minikube --vm-driver=none --kubernetes-version=v1.18.1
-sudo /usr/local/bin/minikube update-context
-
+curl -sfL https://get.k3s.io | bash /dev/stdin --docker
Review Comment:
Using minkube is causing these errors. sample run - https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868
```
stderr:
[573](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:574)
W0117 21:13:37.815530 2352 configset.go:202] WARNING: kubeadm cannot validate component configs for API groups [kubelet.config.k8s.io kubeproxy.config.k8s.io]
[574](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:575)
[WARNING IsDockerSystemdCheck]: detected "cgroupfs" as the Docker cgroup driver. The recommended driver is "systemd". Please follow the guide at https://kubernetes.io/docs/setup/cri/
[575](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:576)
[WARNING Swap]: running with swap on is not supported. Please disable swap
[576](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:577)
[WARNING FileExisting-socat]: socat not found in system path
[577](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:578)
[WARNING SystemVerification]: this Docker version is not on the list of validated versions: 20.10.22+azure-1. Latest validated version: 19.03
[578](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:579)
[WARNING Service-Kubelet]: kubelet service is not enabled, please run 'systemctl enable kubelet.service'
[579](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:580)
W0117 21:13:56.868796 2352 manifests.go:225] the default kube-apiserver authorization-mode is "Node,RBAC"; using "Node,RBAC"
[580](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:581)
W0117 21:13:56.869683 2352 manifests.go:225] the default kube-apiserver authorization-mode is "Node,RBAC"; using "Node,RBAC"
[581](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:582)
error execution phase wait-control-plane: couldn't initialize a Kubernetes cluster
[582](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:583)
To see the stack trace of this error execute with --v=5 or higher
[583](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:584)
[584](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:585)
*
[585](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:586)
* minikube is exiting due to an error. If the above message is not useful, open an issue:
[586](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:587)
- https://github.com/kubernetes/minikube/issues/new/choose
[587](https://github.com/tejaswini-imply/druid/actions/runs/3942544831/jobs/6748042868#step:5:588)
Error: Command execution failed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13782: Use K3S instead of minikube for integration tests
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #13782:
URL: https://github.com/apache/druid/pull/13782#discussion_r1108031016
##########
integration-tests/script/setup_k8s_cluster.sh:
##########
@@ -16,19 +16,13 @@
set -e
-# Set Necessary ENV
-export CHANGE_MINIKUBE_NONE_USER=true
-export MINIKUBE_WANTUPDATENOTIFICATION=false
-export MINIKUBE_WANTREPORTERRORPROMPT=false
-export MINIKUBE_HOME=$HOME
+export INSTALL_K3S_VERSION=v1.21.14+k3s1
export KUBECONFIG=$HOME/.kube/config
-sudo apt install -y conntrack
-
-# Lacunch K8S cluster
+# Launch K8S cluster
curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/v1.18.1/bin/linux/amd64/kubectl && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
-curl -Lo minikube https://storage.googleapis.com/minikube/releases/v1.8.1/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/
-sudo /usr/local/bin/minikube start --profile=minikube --vm-driver=none --kubernetes-version=v1.18.1
-sudo /usr/local/bin/minikube update-context
-
+curl -sfL https://get.k3s.io | bash /dev/stdin --docker
Review Comment:
there is only one test. It seems that GHA runners have minikube installed but I was told that there were some errors. @tejaswini-imply knows what those errors were.
I tried K3S and I felt that it's really lightweight to download and bring up. CI systems is one of the core use cases for K3S.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on a diff in pull request #13782: Use K3S instead of minikube for integration tests
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on code in PR #13782:
URL: https://github.com/apache/druid/pull/13782#discussion_r1107504686
##########
.github/workflows/standard-its.yml:
##########
@@ -100,6 +100,54 @@ jobs:
override_config_path: ./environment-configs/test-groups/custom-coordinator-duties
group: custom coordinator duties
+ integration-k8s-leadership-tests:
+ name: (Compile=openjdk8, Run=openjdk8, Cluster Build On K8s) ITNestedQueryPushDownTest integration test
+ runs-on: ubuntu-22.04
+ env:
+ MVN: mvn --no-snapshot-updates
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
+ CONFIG_FILE: k8s_run_config_file.json
+ IT_TEST: -Dit.test=ITNestedQueryPushDownTest
+ POD_NAME: int-test
+ POD_NAMESPACE: default
+ BUILD_DRUID_CLUSTER: true
+ steps:
+ - name: Checkout branch
+ uses: actions/checkout@v3
+
+ - name: Setup java
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: 8
+
+ - name: Restore Maven repository
+ id: maven-restore
+ uses: actions/cache/restore@v3
+ with:
+ path: ~/.m2/repository
+ key: maven-${{ runner.os }}-8-${{ github.sha }}
+
+ - name: Maven build
+ if: steps.maven-restore.outputs.cache-hit != 'true'
+ run: |
+ ./it.sh ci
Review Comment:
`it.sh ci` builds Druid. We'd like to cache builds across stages to avoid load. Building Druid replaces some jars in the Maven cache. Then, the old ITs do its own build, with its own options, replacing the build done here.
The upshot is, I wonder if we need to do this build? Will the old IT run here do it anyway?
##########
integration-tests/script/setup_k8s_cluster.sh:
##########
@@ -16,19 +16,13 @@
set -e
-# Set Necessary ENV
-export CHANGE_MINIKUBE_NONE_USER=true
-export MINIKUBE_WANTUPDATENOTIFICATION=false
-export MINIKUBE_WANTREPORTERRORPROMPT=false
-export MINIKUBE_HOME=$HOME
+export INSTALL_K3S_VERSION=v1.21.14+k3s1
export KUBECONFIG=$HOME/.kube/config
-sudo apt install -y conntrack
-
-# Lacunch K8S cluster
+# Launch K8S cluster
curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/v1.18.1/bin/linux/amd64/kubectl && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
-curl -Lo minikube https://storage.googleapis.com/minikube/releases/v1.8.1/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/
-sudo /usr/local/bin/minikube start --profile=minikube --vm-driver=none --kubernetes-version=v1.18.1
-sudo /usr/local/bin/minikube update-context
-
+curl -sfL https://get.k3s.io | bash /dev/stdin --docker
Review Comment:
The above download k3s for each test. That is probably a somewhat large task. Should the software be installed in the runner ahead of time? Can we do that? Is some K8s platform already available in the GHA runner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 closed pull request #13782: [Test] Minikube to k3s
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 closed pull request #13782: [Test] Minikube to k3s
URL: https://github.com/apache/druid/pull/13782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on a diff in pull request #13782: [Test] Minikube to k3s
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on code in PR #13782:
URL: https://github.com/apache/druid/pull/13782#discussion_r1107401314
##########
.github/workflows/standard-its.yml:
##########
@@ -100,6 +100,54 @@ jobs:
override_config_path: ./environment-configs/test-groups/custom-coordinator-duties
group: custom coordinator duties
+ integration-k8s-leadership-tests:
+ name: (Compile=openjdk8, Run=openjdk8, Cluster Build On K8s) ITNestedQueryPushDownTest integration test
+ runs-on: ubuntu-22.04
+ env:
+ MVN: mvn --no-snapshot-updates
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
+ CONFIG_FILE: k8s_run_config_file.json
+ IT_TEST: -Dit.test=ITNestedQueryPushDownTest
+ POD_NAME: int-test
+ POD_NAMESPACE: default
+ BUILD_DRUID_CLUSTER: true
+ steps:
+ - name: Checkout branch
+ uses: actions/checkout@v3
+
+ - name: Setup java
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: 8
+
+ - name: Restore Maven repository
+ id: maven-restore
+ uses: actions/cache/restore@v3
+ with:
+ path: ~/.m2/repository
+ key: maven-${{ runner.os }}-8-${{ github.sha }}
+
+ - name: Maven build
+ if: steps.maven-restore.outputs.cache-hit != 'true'
+ run: |
+ ./it.sh ci
+
+ - name: Run IT
+ id: test
+ run: |
+ # Debug echo
+ echo "MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}"
+ MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}
+
+ - name: Debug on failure
+ if: ${{ failure() && steps.test.conclusion == 'failure' }}
+ run: |
+ for v in broker middlemanager router coordinator historical ; do
+ echo "------------------------druid-tiny-cluster-"$v"s-0-------------------------";
+ sudo /usr/local/bin/kubectl logs --tail 1000 druid-tiny-cluster-"$v"s-0;
Review Comment:
The above will emit up to 5000 log lines. Is this what we want? Is there a better way to preserve logs?
##########
.github/workflows/standard-its.yml:
##########
@@ -100,6 +100,54 @@ jobs:
override_config_path: ./environment-configs/test-groups/custom-coordinator-duties
group: custom coordinator duties
+ integration-k8s-leadership-tests:
+ name: (Compile=openjdk8, Run=openjdk8, Cluster Build On K8s) ITNestedQueryPushDownTest integration test
+ runs-on: ubuntu-22.04
+ env:
+ MVN: mvn --no-snapshot-updates
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
+ CONFIG_FILE: k8s_run_config_file.json
+ IT_TEST: -Dit.test=ITNestedQueryPushDownTest
+ POD_NAME: int-test
+ POD_NAMESPACE: default
+ BUILD_DRUID_CLUSTER: true
+ steps:
+ - name: Checkout branch
+ uses: actions/checkout@v3
+
+ - name: Setup java
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: 8
+
+ - name: Restore Maven repository
+ id: maven-restore
+ uses: actions/cache/restore@v3
+ with:
+ path: ~/.m2/repository
+ key: maven-${{ runner.os }}-8-${{ github.sha }}
+
+ - name: Maven build
+ if: steps.maven-restore.outputs.cache-hit != 'true'
+ run: |
+ ./it.sh ci
+
+ - name: Run IT
+ id: test
+ run: |
+ # Debug echo
+ echo "MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}"
+ MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}
Review Comment:
Nit: you'll get more reliable info if we first set `MAVEN_OPTS`, then do `echo $MAVEN_OPTS`. The result avoid copy/paste errors in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] tejaswini-imply commented on a diff in pull request #13782: Use K3S instead of minikube for integration tests
Posted by "tejaswini-imply (via GitHub)" <gi...@apache.org>.
tejaswini-imply commented on code in PR #13782:
URL: https://github.com/apache/druid/pull/13782#discussion_r1108106941
##########
.github/workflows/standard-its.yml:
##########
@@ -100,6 +100,54 @@ jobs:
override_config_path: ./environment-configs/test-groups/custom-coordinator-duties
group: custom coordinator duties
+ integration-k8s-leadership-tests:
+ name: (Compile=openjdk8, Run=openjdk8, Cluster Build On K8s) ITNestedQueryPushDownTest integration test
+ runs-on: ubuntu-22.04
+ env:
+ MVN: mvn --no-snapshot-updates
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
+ CONFIG_FILE: k8s_run_config_file.json
+ IT_TEST: -Dit.test=ITNestedQueryPushDownTest
+ POD_NAME: int-test
+ POD_NAMESPACE: default
+ BUILD_DRUID_CLUSTER: true
+ steps:
+ - name: Checkout branch
+ uses: actions/checkout@v3
+
+ - name: Setup java
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'zulu'
+ java-version: 8
+
+ - name: Restore Maven repository
+ id: maven-restore
+ uses: actions/cache/restore@v3
+ with:
+ path: ~/.m2/repository
+ key: maven-${{ runner.os }}-8-${{ github.sha }}
+
+ - name: Maven build
+ if: steps.maven-restore.outputs.cache-hit != 'true'
+ run: |
+ ./it.sh ci
Review Comment:
This is building only when `steps.maven-restore.outputs.cache-hit != 'true'` so it's not building everytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on pull request #13782: Use K3S instead of minikube for integration tests
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on PR #13782:
URL: https://github.com/apache/druid/pull/13782#issuecomment-1432068230
@abhishekagarwal87, thanks for making this fix. This is a complex area; thanks much for digging into the complex details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org