You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/06/25 03:59:14 UTC
[GitHub] [dolphinscheduler] wordhardqi opened a new issue #5692: [Bug][Spark] When completing data, the time template replacement is not correct.
wordhardqi opened a new issue #5692:
URL: https://github.com/apache/dolphinscheduler/issues/5692
When building the command for spark task, we use `ParameterUtils.convertParameterPlaceholders` which is
```
if (parameterMap != null && null != parameterMap.get(Constants.PARAMETER_DATETIME)) {
//Get current time, schedule execute time
String cronTimeStr = parameterMap.get(Constants.PARAMETER_DATETIME);
cronTime = DateUtils.parse(cronTimeStr, Constants.PARAMETER_FORMAT_TIME);
} else {
cronTime = new Date();
}
```
This function didn't replace $[yyyy-MM-dd] use schedule time as what we did in shell task.
I notice this is a function `ParameterUtils.convertParameterPlaceholders2` which take ` String cronTimeStr = parameterMap.get(Constants.PARAMETER_SHECDULE_TIME);` into consideration, shall we change to that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on issue #5692: [Bug][Spark] When completing data, the time template replacement is not correct.
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #5692:
URL: https://github.com/apache/dolphinscheduler/issues/5692#issuecomment-868662275
good job, we should be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wordhardqi commented on issue #5692: [Bug][Spark] When completing data, the time template replacement is not correct.
Posted by GitBox <gi...@apache.org>.
wordhardqi commented on issue #5692:
URL: https://github.com/apache/dolphinscheduler/issues/5692#issuecomment-869300884
the pr is https://github.com/apache/dolphinscheduler/pull/5695/commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5692: [Bug][Spark] When completing data, the time template replacement is not correct.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5692:
URL: https://github.com/apache/dolphinscheduler/issues/5692#issuecomment-868184584
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wordhardqi commented on issue #5692: [Bug][Spark] When completing data, the time template replacement is not correct.
Posted by GitBox <gi...@apache.org>.
wordhardqi commented on issue #5692:
URL: https://github.com/apache/dolphinscheduler/issues/5692#issuecomment-868185055
The behavior is that if we completing data for spark job, all instances will use the current date time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng closed issue #5692: [Bug][Spark] When completing data, the time template replacement is not correct.
Posted by GitBox <gi...@apache.org>.
caishunfeng closed issue #5692:
URL: https://github.com/apache/dolphinscheduler/issues/5692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org