You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "smallzhongfeng (via GitHub)" <gi...@apache.org> on 2023/03/31 08:40:32 UTC
[GitHub] [incubator-uniffle] smallzhongfeng opened a new pull request, #786: [MINOR] Avoid returning null values in `defaultUserApps`
smallzhongfeng opened a new pull request, #786:
URL: https://github.com/apache/incubator-uniffle/pull/786
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
`map.getOrDefault()` => `map.computeIfAbsent()`
### Why are the changes needed?
If do not define the user and app num in the quota configuration file, it will appear that the `defaultUserApps` does not have the corresponding app number for this user, because we did not include the `quotaAppNum` in the `defaultUserApps`.
**before** :
The log from coordinator is `[ERROR] 2023-03-28 19:24:11,18 Grpc-260 AccessAppQuotaChecker check - Denied by AccessAppQuotaChecker => User: xxxx, current app num is: 3, default app num is: null.`
**after** :
The log from coordinator is `[ERROR] 2023-03-31 14:32:21,228 Grpc-240 AccessAppQuotaChecker check - Denied by AccessAppQuotaChecker => User: xxxx, current app num is: 3, default app num is: 3.`
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Origin uts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #786: [MINOR] Avoid returning null in `defaultUserApps` when quota file does't config user
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on PR #786:
URL: https://github.com/apache/incubator-uniffle/pull/786#issuecomment-1491630326
cc @jerqi @zuston @leixm Not a big change. Thanks :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #786: [MINOR] Avoid returning null in `defaultUserApps` when quota file does't config user
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #786:
URL: https://github.com/apache/incubator-uniffle/pull/786#issuecomment-1491789289
Thanks @smallzhongfeng Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #786: [MINOR] Avoid returning null in `defaultUserApps` when quota file does't config user
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #786:
URL: https://github.com/apache/incubator-uniffle/pull/786#issuecomment-1506230458
@smallzhongfeng There is a fix. It should be merged to branch 0.7. But there is conflicts with branch 0.7. Could you raise a pr to branch 0.7?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston merged pull request #786: [MINOR] Avoid returning null in `defaultUserApps` when quota file does't config user
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #786:
URL: https://github.com/apache/incubator-uniffle/pull/786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #786: [MINOR] Avoid returning null in `defaultUserApps` when quota file does't config user
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #786:
URL: https://github.com/apache/incubator-uniffle/pull/786#issuecomment-1491557191
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/786?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#786](https://codecov.io/gh/apache/incubator-uniffle/pull/786?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af1dcfc) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/ea5a3ba45b923b1afc8fda0fdb0546daf34274fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea5a3ba) will **increase** coverage by `1.45%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #786 +/- ##
============================================
+ Coverage 57.86% 59.31% +1.45%
Complexity 2028 2028
============================================
Files 298 284 -14
Lines 14520 12554 -1966
Branches 1185 1185
============================================
- Hits 8402 7447 -955
+ Misses 5643 4690 -953
+ Partials 475 417 -58
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/uniffle/coordinator/QuotaManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvUXVvdGFNYW5hZ2VyLmphdmE=) | `84.41% <100.00%> (ø)` | |
... and [17 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/786/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #786: [MINOR] Avoid returning null in `defaultUserApps` when quota file does't config user
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #786:
URL: https://github.com/apache/incubator-uniffle/pull/786#issuecomment-1491749430
LGTM. I hadn't noticed this difference between `getOrDefault` and `computeIfAbsent` before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #786: [MINOR] Avoid returning null in `defaultUserApps` when quota file does't config user
Posted by "smallzhongfeng (via GitHub)" <gi...@apache.org>.
smallzhongfeng commented on PR #786:
URL: https://github.com/apache/incubator-uniffle/pull/786#issuecomment-1493571296
Thanks for your review! @zuston
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org