You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Emily Yeh (JIRA)" <ji...@apache.org> on 2017/07/19 19:04:00 UTC
[jira] [Updated] (GEODE-3252) Refactor all gfsh commands into
separate classes
[ https://issues.apache.org/jira/browse/GEODE-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emily Yeh updated GEODE-3252:
-----------------------------
Description:
Many gfsh command classes are huge because they contain multiple commands and the methods they share. Code quality could be improved by refactoring all of these commands into their own separate classes and moving the methods they share to other appropriately named classes. The tests associated with these giant classes should also be split into smaller tests that deal with separate commands.
Below is a list of classes that may need to be refactored:
{noformat}
ClientCommands
CommandAvailabilityIndicator
ConfigCommands
CreateAlterDestroyRegionCommands
DataCommands
DeployCommands
DiskStoreCommands
DurableClientCommands
ExportImportClusterConfigurationCommands
ExportLogsCommand
ExportLogsInterceptor
FunctionCommands
GfshHelpCommands
IndexCommands
LauncherLifecycleCommands
LauncherSignalListener
MemberCommands
MiscellaneousCommands
PDXCommands
QueueCommands
RegionCommands
ShellCommands
StatusCommands
WanCommands
{noformat}
was:Many gfsh command classes are huge because they contain multiple commands and the methods they share. Code quality could be improved by refactoring all of these commands into their own separate classes and moving the methods they share to other appropriately named classes. The tests associated with these giant classes should also be split into smaller tests that deal with separate commands.
> Refactor all gfsh commands into separate classes
> ------------------------------------------------
>
> Key: GEODE-3252
> URL: https://issues.apache.org/jira/browse/GEODE-3252
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Emily Yeh
>
> Many gfsh command classes are huge because they contain multiple commands and the methods they share. Code quality could be improved by refactoring all of these commands into their own separate classes and moving the methods they share to other appropriately named classes. The tests associated with these giant classes should also be split into smaller tests that deal with separate commands.
> Below is a list of classes that may need to be refactored:
> {noformat}
> ClientCommands
> CommandAvailabilityIndicator
> ConfigCommands
> CreateAlterDestroyRegionCommands
> DataCommands
> DeployCommands
> DiskStoreCommands
> DurableClientCommands
> ExportImportClusterConfigurationCommands
> ExportLogsCommand
> ExportLogsInterceptor
> FunctionCommands
> GfshHelpCommands
> IndexCommands
> LauncherLifecycleCommands
> LauncherSignalListener
> MemberCommands
> MiscellaneousCommands
> PDXCommands
> QueueCommands
> RegionCommands
> ShellCommands
> StatusCommands
> WanCommands
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)