You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2025/09/22 04:26:56 UTC

[PR] chore: Fuse in and out handler for setupStage [pekko]

He-Pin opened a new pull request, #2259:
URL: https://github.com/apache/pekko/pull/2259

   Motivation:
   Much easier to reason about and less allocation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Fuse in and out handler for setupStage [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2259:
URL: https://github.com/apache/pekko/pull/2259#discussion_r2367219488


##########
stream/src/main/scala/org/apache/pekko/stream/impl/SetupStage.scala:
##########
@@ -46,33 +46,43 @@ import pekko.stream.stage.OutHandler
   }
 
   @scala.annotation.nowarn("msg=inferred structural type")

Review Comment:
   can you remove the annotation above?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Fuse in and out handler for setupStage [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #2259:
URL: https://github.com/apache/pekko/pull/2259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] chore: Fuse in and out handler for setupStage [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2259:
URL: https://github.com/apache/pekko/pull/2259#discussion_r2367219488


##########
stream/src/main/scala/org/apache/pekko/stream/impl/SetupStage.scala:
##########
@@ -46,33 +46,43 @@ import pekko.stream.stage.OutHandler
   }
 
   @scala.annotation.nowarn("msg=inferred structural type")

Review Comment:
   can you remove the annotation above?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org