You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by em...@apache.org on 2021/02/19 18:59:59 UTC
[groovy] branch master updated: GROOVY-7996: restrict to non-static
get/set/propertyMissing
This is an automated email from the ASF dual-hosted git repository.
emilles pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git
The following commit(s) were added to refs/heads/master by this push:
new 6877d56 GROOVY-7996: restrict to non-static get/set/propertyMissing
6877d56 is described below
commit 6877d5668ba0660bd3756829452c140967e0cb81
Author: Eric Milles <er...@thomsonreuters.com>
AuthorDate: Fri Feb 19 12:54:53 2021 -0600
GROOVY-7996: restrict to non-static get/set/propertyMissing
---
.../org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java b/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
index f3eb159..99e8ab1 100644
--- a/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
+++ b/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
@@ -1596,7 +1596,7 @@ public class StaticTypeCheckingVisitor extends ClassCodeVisitorSupport {
}
}
- // GROOVY-7996: check if receiver implements get(String)/set(String,Object) or propertyMissing(String)
+ // GROOVY-7996: check if receiver implements get(String)/set(String,Object) or propertyMissing(String) or $static_propertyMissing(String)?
if (!receiverType.isArray() && !isPrimitiveType(getUnwrapper(receiverType))
&& pexp.isImplicitThis() && typeCheckingContext.getEnclosingClosure() != null) {
MethodNode mopMethod;
@@ -1607,7 +1607,7 @@ public class StaticTypeCheckingVisitor extends ClassCodeVisitorSupport {
}
if (mopMethod == null) mopMethod = receiverType.getMethod("propertyMissing", new Parameter[]{new Parameter(STRING_TYPE, "propertyName")});
- if (mopMethod != null && !mopMethod.isSynthetic()) {
+ if (mopMethod != null && !mopMethod.isStatic() && !mopMethod.isSynthetic()) {
pexp.putNodeMetaData(DYNAMIC_RESOLUTION, Boolean.TRUE);
pexp.removeNodeMetaData(DECLARATION_INFERRED_TYPE);
pexp.removeNodeMetaData(INFERRED_TYPE);