You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2026/10/23 08:33:36 UTC

[PR] Add module guidance and shared unordered IT assertions [iotdb]

JackieTien97 opened a new pull request, #19001:
URL: https://github.com/apache/iotdb/pull/19001

   ## Description
   
   Agent guidance is centralized despite module-specific build, grammar, and dependency constraints, while the GROUP BY TAGS IT duplicates per-node result comparison logic.
   
   - Add scoped AGENTS.md guides for AINode, both SQL grammar modules, node/calc commons, distribution, and scripts. Link them from the root, move existing specialized rules to their owning modules, and require semantically equivalent, narrowly scoped backports from master to dev/1.3.
   - Add a tree-model SQL entry point that reuses the existing per-node unordered result comparison. Replace the GROUP BY TAGS test's local comparison loop with this helper, retaining header, value, and duplicate-count checks, and document its use in the IT guide.
   
   ## Validation
   
   - Spotless and Markdown/license-header/local-link checks passed.
   - Targeted clean reactor verification passed on the PR commit with ClusterIT and HighPerformanceMode (1 ConfigNode, 3 DataNodes): 7 tests, 0 failures, 0 errors, 0 skipped.
   - Tests: IoTDBTimeDurationIT#testTimeDurationManyColumnOnManyDataRegion and all 6 IoTDBClusterResultSetIT cases, including differing node order and duplicate multiplicity.
   
   ```bash
   mvn -o clean verify -pl integration-test -am \
     -PClusterIT,with-integration-tests -DskipUTs \
     '-Dit.test=IoTDBTimeDurationIT#testTimeDurationManyColumnOnManyDataRegion,IoTDBClusterResultSetIT' \
     -DClusterConfigurations=HighPerformanceMode \
     '-DintegrationTest.includedGroups=org.apache.iotdb.itbase.category.ClusterIT,org.apache.iotdb.itbase.category.TableClusterIT' \
     -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false
   ```
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added documentation for new or modified behaviors.
   - [x] added Javadoc for the shared helper.
   - [x] modified an existing integration test and been tested in a test IoTDB cluster.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add module guidance and shared unordered IT assertions [iotdb]

Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #19001:
URL: https://github.com/apache/iotdb/pull/19001


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add module guidance and shared unordered IT assertions [iotdb]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #19001:
URL: https://github.com/apache/iotdb/pull/19001#issuecomment-6361625407

   ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/19001?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 47.64%. Comparing base ([`316c93b`](https://app.codecov.io/gh/apache/iotdb/commit/316c93bd3157cd67c53c8fa69392bcb0ee505cef?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7631362`](https://app.codecov.io/gh/apache/iotdb/commit/7631362f53a9339390c5f178de31c9dfa38bdc3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 4 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19001      +/-   ##
   ============================================
   + Coverage     47.63%   47.64%   +0.01%     
     Complexity      806      806              
   ============================================
     Files          5562     5562              
     Lines        408297   408384      +87     
     Branches      53589    53610      +21     
   ============================================
   + Hits         194475   194566      +91     
   + Misses       213822   213818       -4     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/19001?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add module guidance and shared unordered IT assertions [iotdb]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #19001:
URL: https://github.com/apache/iotdb/pull/19001#issuecomment-6361098992

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=19001) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [E Reliability Rating on New Code](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=19001&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) (required ≥ A)  
     
   <!-- sqra:qg_revision=bd59fb0df29fbe8fc0c1b9c2fad11e0355db347b08e418e3dc66153e7ecbf67e -->
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=19001)
   
   ##   
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png '') [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org