You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/05 07:04:02 UTC

[GitHub] [superset] kamalkeshavani-aiinside opened a new issue #15539: Broken OMNIBAR feature

kamalkeshavani-aiinside opened a new issue #15539:
URL: https://github.com/apache/superset/issues/15539


   This experimental feature is broken in latest versions.
   https://github.com/apache/superset/pull/6745
   
   ### Expected results
   When typing in Omnibar, a dropdown should appear to select from search results.
   
   ### Actual results
   The window with search text box and dropdown is very small, making it hard to use the dropdown.
   
   
   #### Screenshots
   From PR:
   ![image](https://user-images.githubusercontent.com/74634977/124430089-b0c76080-dda9-11eb-9d4b-ede69fcd8666.png)
   
   Current situation in Master:
   ![image](https://user-images.githubusercontent.com/74634977/124430176-cdfc2f00-dda9-11eb-90bf-30e90f56953e.png)
   
   
   #### How to reproduce the bug
   
   1. Enable `OMNIBAR` feature flag.
   2. Go to any dashboard and press Cmd + K
   3. Type any text and it should show available dashboards
   ![omnibar](https://user-images.githubusercontent.com/74634977/124429087-65608280-dda8-11eb-9b97-c46507a7cf4f.gif)
   ### Environment
   
   - superset version: `master`
   using image from docker hub
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   I would also request a feature here:
   Close the OMNIBAR when ESC key is pressed. Currently Omnibar cannot be closed without refreshing the page.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido closed issue #15539: [dashboard]Broken OMNIBAR feature

Posted by GitBox <gi...@apache.org>.
geido closed issue #15539:
URL: https://github.com/apache/superset/issues/15539


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #15539: [dashboard]Broken OMNIBAR feature

Posted by GitBox <gi...@apache.org>.
geido commented on issue #15539:
URL: https://github.com/apache/superset/issues/15539#issuecomment-895923207


   I am back on this one now 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #15539: Broken OMNIBAR feature

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15539:
URL: https://github.com/apache/superset/issues/15539#issuecomment-874951187


   sorry for breaking the feature, i didn't know this feature exists😅 , we will bring it back soon. 
   @rosemarie-chiu @jinghua-qa please add this test case. 🙏 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #15539: [dashboard]Broken OMNIBAR feature

Posted by GitBox <gi...@apache.org>.
geido commented on issue #15539:
URL: https://github.com/apache/superset/issues/15539#issuecomment-885631521


   I am moving away from this one as I have got priority items to solve. I will wait for your decision concerning prioritization for this one @junlincc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #15539: [dashboard]Broken OMNIBAR feature

Posted by GitBox <gi...@apache.org>.
geido commented on issue #15539:
URL: https://github.com/apache/superset/issues/15539#issuecomment-879895681


   I am having a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org