You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/10/03 17:28:59 UTC

[GitHub] spark pull request #22603: [SPARK-25062][SQL] Clean up BlockLocations in InM...

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22603#discussion_r222397997
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala ---
    @@ -315,7 +315,13 @@ object InMemoryFileIndex extends Logging {
             // which is very slow on some file system (RawLocalFileSystem, which is launch a
             // subprocess and parse the stdout).
             try {
    -          val locations = fs.getFileBlockLocations(f, 0, f.getLen)
    +          val locations = fs.getFileBlockLocations(f, 0, f.getLen).map { loc =>
    --- End diff --
    
    Hi, @peter-toth .
    Could you add one line comment to explain this conversion?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org