[GitHub] [pulsar] eolivelli commented on a change in pull request #12025: the traffic of ns which bound to a region would not be sent to bookie…

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r712114156



##########
File path: pulsar-zookeeper-utils/src/test/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicyTest.java
##########
@@ -137,9 +167,12 @@ public void testBasic() throws Exception {
 
         Set<BookieId> bookieToExclude = new HashSet<>();
         bookieToExclude.add(new BookieSocketAddress(BOOKIE1).toBookieId());
-        ensemble = isolationPolicy.newEnsemble(2, 2, 2, Collections.emptyMap(), bookieToExclude).getResult();
-        assertTrue(ensemble.contains(new BookieSocketAddress(BOOKIE4).toBookieId()));
-        assertTrue(ensemble.contains(new BookieSocketAddress(BOOKIE2).toBookieId()));
+        try {

Review comment:
       why the behaviour of this test is changing ?
   was the test wrong ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org