You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/05/02 13:41:19 UTC
svn commit: r1889407 -
/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
Author: tilman
Date: Sun May 2 13:41:19 2021
New Revision: 1889407
URL: http://svn.apache.org/viewvc?rev=1889407&view=rev
Log:
PDFBOX-4892: optimize, as suggested by valerybokov; clarify code
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java?rev=1889407&r1=1889406&r2=1889407&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDDocument.java Sun May 2 13:41:19 2021
@@ -392,15 +392,16 @@ public class PDDocument implements Close
}
PDSignatureField signatureField = null;
- if (!(acroForm.getCOSObject().getDictionaryObject(COSName.FIELDS) instanceof COSArray))
+ COSBase cosFieldBase = acroForm.getCOSObject().getDictionaryObject(COSName.FIELDS);
+ if (cosFieldBase instanceof COSArray)
{
- acroForm.getCOSObject().setItem(COSName.FIELDS, new COSArray());
+ COSArray fieldArray = (COSArray) cosFieldBase;
+ fieldArray.setNeedToBeUpdated(true);
+ signatureField = findSignatureField(acroForm.getFieldIterator(), sigObject);
}
else
{
- COSArray fieldArray = (COSArray) acroForm.getCOSObject().getDictionaryObject(COSName.FIELDS);
- fieldArray.setNeedToBeUpdated(true);
- signatureField = findSignatureField(acroForm.getFieldIterator(), sigObject);
+ acroForm.getCOSObject().setItem(COSName.FIELDS, new COSArray());
}
if (signatureField == null)
{