You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mustafasrepo (via GitHub)" <gi...@apache.org> on 2023/11/10 15:40:10 UTC

Re: [I] Overlapping `ExecutionPlan::maintains_input_order(), equivalence_properties and maintains_input_order` are confusing [arrow-datafusion]

mustafasrepo commented on issue #8120:
URL: https://github.com/apache/arrow-datafusion/issues/8120#issuecomment-1805960165

   @alamb I agree with you we could simplify the API, to prevent inconsistent usage. However, I think keeping `maintains_input_order` and `equivalence_properties` is better option. `output_ordering` information is already in the `equivalence_properties`. We can default implement `output_ordering` as 
   ```rust
   self.equivalence_properties.output_ordering()
   ```
   This way, when some one loses `input_ordering` since they didn't implement `equivalence_properties`. `output_ordering` would simply be `None`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org