You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/07/29 05:19:27 UTC
[lucene-solr] 06/06: @450 Remove out of place check that you cant
create a core with no node name.
This is an automated email from the ASF dual-hosted git repository.
markrmiller pushed a commit to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
commit 9747c86524f32d6bd3abde664da4e98be2acfac5
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Tue Jul 28 23:04:06 2020 -0500
@450 Remove out of place check that you cant create a core with no node name.
---
.../solr/cloud/DeleteInactiveReplicaTest.java | 33 ++++++++++------------
1 file changed, 15 insertions(+), 18 deletions(-)
diff --git a/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java b/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java
index 0705511..8c98791 100644
--- a/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java
@@ -75,8 +75,6 @@ public class DeleteInactiveReplicaTest extends SolrCloudTestCase {
}
cluster.stopJettySolrRunner(jetty);
- cluster.waitForJettyToStop(jetty);
-
waitForState("Expected replica " + replica.getName() + " on down node to be removed from cluster state", collectionName, (n, c) -> {
Replica r = c.getReplica(replica.getCoreName());
return r == null || r.getState() != Replica.State.ACTIVE;
@@ -91,21 +89,20 @@ public class DeleteInactiveReplicaTest extends SolrCloudTestCase {
return c.getReplica(replica.getCoreName()) == null;
});
- cluster.startJettySolrRunner(jetty);
- log.info("restarted jetty");
-
- // Check that we can't create a core with no coreNodeName
- try (SolrClient queryClient = getHttpSolrClient(jetty.getBaseUrl().toString())) {
- Exception e = expectThrows(Exception.class, () -> {
- CoreAdminRequest.Create createRequest = new CoreAdminRequest.Create();
- createRequest.setCoreName("testcore");
- createRequest.setCollection(collectionName);
- createRequest.setShardId("shard2");
- queryClient.request(createRequest);
- });
- assertTrue("Unexpected error message: " + e.getMessage(), e.getMessage().contains("No coreNodeName for"));
-
- }
+// cluster.startJettySolrRunner(jetty);
+// log.info("restarted jetty");
+//
+// // Check that we can't create a core with no coreNodeName
+// try (SolrClient queryClient = getHttpSolrClient(jetty.getBaseUrl().toString())) {
+// Exception e = expectThrows(Exception.class, () -> {
+// CoreAdminRequest.Create createRequest = new CoreAdminRequest.Create();
+// createRequest.setCoreName("testcore");
+// createRequest.setCollection(collectionName);
+// createRequest.setShardId("shard2");
+// queryClient.request(createRequest);
+// });
+// assertTrue("Unexpected error message: " + e.getMessage(), e.getMessage().contains("No coreNodeName for"));
+//
+// }
}
-
}