You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/07 15:06:55 UTC

[GitHub] [arrow] Dandandan commented on a change in pull request #9924: ARROW-12235: [Rust][DataFusion] LIMIT returns incorrect results when used with several small partitions

Dandandan commented on a change in pull request #9924:
URL: https://github.com/apache/arrow/pull/9924#discussion_r608742081



##########
File path: rust/datafusion/src/physical_plan/limit.rs
##########
@@ -183,8 +183,8 @@ impl ExecutionPlan for LocalLimitExec {
         }
     }
 
-    async fn execute(&self, _: usize) -> Result<SendableRecordBatchStream> {
-        let stream = self.input.execute(0).await?;
+    async fn execute(&self, partition: usize) -> Result<SendableRecordBatchStream> {
+        let stream = self.input.execute(partition).await?;

Review comment:
       💯 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org