You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2019/10/15 11:39:06 UTC
[Impala-ASF-CR] WIP: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14444
Change subject: WIP: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
WIP: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
---
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/common/impala_test_suite.py
M tests/stress/test_acid_stress.py
6 files changed, 186 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/14444/1
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Norbert Luksa, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14444
to look at the new patch set (#4).
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Added different stress tests for ACID operations. We already had one
stress test where an Impala client issued SELECTs while another process
inserted data through Hive. The test checked wether some invariants are
held.
I added the following tests:
* one Impala client inserts data, one Impala client reads and checks
invariants
* multiple Impala clients issue INSERTs and TRUNCATEs, multiple Impala
clients issue SELECTs and check invariants
* multiple Impala clients insert data, sometimes failures are injected
during inserts to create aborted transactions. In the meantime
multiple Impala clients read the data and check that if they see
data from aborted transactions
During the tests I found and fixed a temporal deadlock.
CatalogOpExecutor.truncateTable() locked catalog_.versionLock_ and the
HMS ACID lock in a different order than the INSERT statements, it could
lead to a deadlock for 30 seconds, after that TRUNCATE failed.
Also, in the Frontend I switched the order of write id allocation and
locking. From now on at first we lock the table then allocate a write
id.
Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
---
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/catalog/Transaction.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/common/impala_test_suite.py
M tests/stress/test_acid_stress.py
7 files changed, 380 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/14444/4
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14444/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/14444/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@753
PS4, Line 753: if(catalog_.getLock().isWriteLockedByCurrentThread()) {
: LOG.error("Write lock should have been released.");
: catalog_.getLock().writeLock().unlock();
: }
It would be nice to create a function for this, I just can't find a good name :D
Maybe UnlockWriteLockIfErronouslyLocked()
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Oct 2019 17:48:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: WIP: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/14444/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:
http://gerrit.cloudera.org:8080/#/c/14444/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@723
PS1, Line 723: LOG.info("Txn id (" + Long.toString(txnId) + ") lock " + Long.toString(lockId) + " is busy, waiting " +
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/14444/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/14444/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1917
PS1, Line 1917: throw new InternalException(String.format("Error truncating table %s due to lock " +
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/14444/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/14444/1/tests/common/impala_test_suite.py@219
PS1, Line 219: #
flake8: E265 block comment should start with '# '
http://gerrit.cloudera.org:8080/#/c/14444/1/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:
http://gerrit.cloudera.org:8080/#/c/14444/1/tests/stress/test_acid_stress.py@47
PS1, Line 47: def run_tasks(tasks):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/14444/1/tests/stress/test_acid_stress.py@191
PS1, Line 191: n
flake8: E713 test for membership should be 'not in'
http://gerrit.cloudera.org:8080/#/c/14444/1/tests/stress/test_acid_stress.py@244
PS1, Line 244: x
flake8: E501 line too long (113 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/14444/1/tests/stress/test_acid_stress.py@245
PS1, Line 245: e
flake8: E501 line too long (128 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2019 11:40:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14444
to look at the new patch set (#2).
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Added different stress tests for ACID operations. We already had one
stress test where an Impala client issued SELECTs while another process
inserted data through Hive. The test checked wether some invariants are
held.
I added the following tests:
* one Impala client inserts data, one Impala client reads and checks
invariants
* multiple Impala clients issue INSERTs and TRUNCATEs, multiple Impala
clients issue SELECTs and check invariants
* multiple Impala clients insert data, sometimes failures are injected
during inserts to create aborted transactions. In the meantime
multiple Impala clients read the data and check that if they see
data from aborted transactions
During the tests I found and fixed a temporal deadlock.
CatalogOpExecutor.truncateTable() locked catalog_.versionLock_ and the
HMS ACID lock in a different order than the INSERT statements, it could
lead to a deadlock for 30 seconds, after that TRUNCATE failed.
Also, in the Frontend I switched the order of write id allocation and
locking. From now on at first we lock the table then allocate a write
id.
Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
---
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/common/impala_test_suite.py
M tests/stress/test_acid_stress.py
6 files changed, 356 insertions(+), 98 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/14444/2
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Nov 2019 15:50:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 11:08:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4828/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Oct 2019 16:14:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5188/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 11:08:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/common/impala_test_suite.py@219
PS2, Line 219: #
flake8: E265 block comment should start with '# '
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@48
PS2, Line 48: def run_tasks(tasks):
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Oct 2019 15:34:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14444/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/14444/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@753
PS4, Line 753: if(catalog_.getLock().isWriteLockedByCurrentThread()) {
: LOG.error("Write lock should have been released.");
: catalog_.getLock().writeLock().unlock();
: }
> It would be nice to create a function for this, I just can't find a good na
I couldn't come up with a better name either.
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Nov 2019 15:31:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Norbert Luksa, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14444
to look at the new patch set (#5).
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Added different stress tests for ACID operations. We already had one
stress test where an Impala client issued SELECTs while another process
inserted data through Hive. The test checked wether some invariants are
held.
I added the following tests:
* one Impala client inserts data, one Impala client reads and checks
invariants
* multiple Impala clients issue INSERTs and TRUNCATEs, multiple Impala
clients issue SELECTs and check invariants
* multiple Impala clients insert data, sometimes failures are injected
during inserts to create aborted transactions. In the meantime
multiple Impala clients read the data and check that if they see
data from aborted transactions
During the tests I found and fixed a temporal deadlock.
CatalogOpExecutor.truncateTable() locked catalog_.versionLock_ and the
HMS ACID lock in a different order than the INSERT statements, it could
lead to a deadlock for 30 seconds, after that TRUNCATE failed.
Also, in the Frontend I switched the order of write id allocation and
locking. From now on at first we lock the table then allocate a write
id.
Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
---
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/catalog/Transaction.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/common/impala_test_suite.py
M tests/stress/test_acid_stress.py
7 files changed, 376 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/14444/5
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14444/3/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:
http://gerrit.cloudera.org:8080/#/c/14444/3/tests/stress/test_acid_stress.py@281
PS3, Line 281:
flake8: E999 IndentationError: unexpected indent
http://gerrit.cloudera.org:8080/#/c/14444/3/tests/stress/test_acid_stress.py@281
PS3, Line 281: r
flake8: E113 unexpected indentation
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Oct 2019 16:36:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4962/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Nov 2019 16:09:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Added different stress tests for ACID operations. We already had one
stress test where an Impala client issued SELECTs while another process
inserted data through Hive. The test checked wether some invariants are
held.
I added the following tests:
* one Impala client inserts data, one Impala client reads and checks
invariants
* multiple Impala clients issue INSERTs and TRUNCATEs, multiple Impala
clients issue SELECTs and check invariants
* multiple Impala clients insert data, sometimes failures are injected
during inserts to create aborted transactions. In the meantime
multiple Impala clients read the data and check that if they see
data from aborted transactions
During the tests I found and fixed a temporal deadlock.
CatalogOpExecutor.truncateTable() locked catalog_.versionLock_ and the
HMS ACID lock in a different order than the INSERT statements, it could
lead to a deadlock for 30 seconds, after that TRUNCATE failed.
Also, in the Frontend I switched the order of write id allocation and
locking. From now on at first we lock the table then allocate a write
id.
Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Reviewed-on: http://gerrit.cloudera.org:8080/14444
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/catalog/Transaction.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/common/impala_test_suite.py
M tests/stress/test_acid_stress.py
7 files changed, 376 insertions(+), 104 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 2:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/14444/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/14444/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1854
PS2, Line 1854: tryLock(table, "truncating");
As we have discussed in person, this locking only protects against the specific case when a table is upgraded in Impala from non-ACID to ACID after the call to getExistingTable(). I think we generally do not handle this case.
I am ok with either keeping or removing this locking, but if we keep it, then some comments about its purpose would be nice.
http://gerrit.cloudera.org:8080/#/c/14444/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1873
PS2, Line 1873: Preconditions.checkState(!catalog_.getLock().isWriteLockedByCurrentThread());
This looks a bit dangerous - if we throw an exception when we have the catalog lock, then it won't be released.
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@164
PS2, Line 164: Task(self._hive_role_write_inserts, tbl_name, partitioned),
nit: here and at other places: doesn't this need indentation of 4?
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@219
PS2, Line 219: tbl_name, wid, num_inserts))
nit: +2 indent
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@223
PS2, Line 223: except Exception as e:
: # Some transactions might fail due to high contention.
: print str(e)
: if "TransactionException" not in str(e):
: raise e
I think it would be better not to swallow these exceptions if possible.
If truncate would get the HMS lock before the catalog's table lock, then the "big waits" (when TRUNCATE waits for exclusive lock or INSERT's shared lock is blocked by a TRUNCATE's exclusive lock) would happen when waiting for HMS locks, which seems more normal than waiting long for catalog locks, and should have longer timeouts.
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@314
PS2, Line 314: "TransactionException" not in str(e) and
: "CLIENT_REQUEST_UPDATE_CATALOG" not in str(e)
Same as line 223. CLIENT_REQUEST_UPDATE_CATALOG errors could be accepted only if the debug action was inserted.
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@343
PS2, Line 343: self.client.execute("""create table %s (i int) TBLPROPERTIES (
Similarly to TestAcidInsertsBasic, I think it would be nice to run the same tests on partitioned tables, e.g. with writing to different partitions randomly. This seems like a "cheap" way to cover more code. I am ok with leaving this as a TODO.
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@353
PS2, Line 353: checker
nit: this could be "checkers", as there can be several of them
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@354
PS2, Line 354: num_writers)
nit: would fit to last line
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Oct 2019 15:16:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 3:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/4872/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Oct 2019 17:19:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 3:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/14444/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/14444/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1854
PS2, Line 1854: }
> As we have discussed in person, this locking only protects against the spec
Added comments about it.
http://gerrit.cloudera.org:8080/#/c/14444/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1873
PS2, Line 1873: newCatalogVersion = truncateTransactionalTable(params, table);
> This looks a bit dangerous - if we throw an exception when we have the cata
You are right, fixed it here and other places in this file.
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/common/impala_test_suite.py@219
PS2, Line 219: #
> flake8: E265 block comment should start with '# '
Done
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@48
PS2, Line 48:
> flake8: E302 expected 2 blank lines, found 1
Done
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@164
PS2, Line 164: run_tasks([
> nit: here and at other places: doesn't this need indentation of 4?
Done
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@219
PS2, Line 219: impalad_client.execute("insert into table %s values (%i, %i)" % (
> nit: +2 indent
Done
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@223
PS2, Line 223: impalad_client.execute("truncate table %s" % tbl_name)
: except Exception as e:
: # Some transactions might fail due to high contention.
: # print str(e)
: # if "Tra
> I think it would be better not to swallow these exceptions if possible.
In this PS when truncate tries to acquire the HMS lock it already released the catalog's table lock. And after it acquired the HMS lock it tries to acquire the catalog table lock again.
I did a closer look at why we get this exception, and it turned out that setting DataOperationType to DELETE for truncate was not the best choice because HMS's conflict detection kicked in and aborted some transactions. Now I set DataOperationType to NO_TXN (which is still not the best because we do have a transaction) and things work just fine.
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@314
PS2, Line 314: if should_succeed or "CLIENT_REQUEST_UPDATE_CATALOG" not in str(e):
: raise e
> Same as line 223. CLIENT_REQUEST_UPDATE_CATALOG errors could be accepted on
Removed TransactionException, and added 'or val == 1'.
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@343
PS2, Line 343: num_writers = 3
> Similarly to TestAcidInsertsBasic, I think it would be nice to run the same
Done
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@353
PS2, Line 353: ytest.m
> nit: this could be "checkers", as there can be several of them
Done
http://gerrit.cloudera.org:8080/#/c/14444/2/tests/stress/test_acid_stress.py@354
PS2, Line 354: @pytest.mark.stress
> nit: would fit to last line
Done
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Oct 2019 16:37:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4873/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Oct 2019 17:19:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 15:40:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14444 )
Change subject: WIP: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4794/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2019 12:20:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Norbert Luksa, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14444
to look at the new patch set (#3).
Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................
IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
Added different stress tests for ACID operations. We already had one
stress test where an Impala client issued SELECTs while another process
inserted data through Hive. The test checked wether some invariants are
held.
I added the following tests:
* one Impala client inserts data, one Impala client reads and checks
invariants
* multiple Impala clients issue INSERTs and TRUNCATEs, multiple Impala
clients issue SELECTs and check invariants
* multiple Impala clients insert data, sometimes failures are injected
during inserts to create aborted transactions. In the meantime
multiple Impala clients read the data and check that if they see
data from aborted transactions
During the tests I found and fixed a temporal deadlock.
CatalogOpExecutor.truncateTable() locked catalog_.versionLock_ and the
HMS ACID lock in a different order than the INSERT statements, it could
lead to a deadlock for 30 seconds, after that TRUNCATE failed.
Also, in the Frontend I switched the order of write id allocation and
locking. From now on at first we lock the table then allocate a write
id.
Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
---
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/catalog/Transaction.java
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M tests/common/impala_test_suite.py
M tests/stress/test_acid_stress.py
7 files changed, 387 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/14444/3
--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>