[GitHub] [spark] beliefer commented on a diff in pull request #39017: [SPARK-41440][CONNECT][PYTHON] Implement `DataFrame.randomSplit`

[GitBox <gi...@apache.org>]

beliefer commented on code in PR #39017:
URL: https://github.com/apache/spark/pull/39017#discussion_r1046585027


##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -601,3 +602,10 @@ message Unpivot {
   // (Required) Name of the value column.
   string value_column_name = 5;
 }
+
+// Randomly splits this Dataset with the provided weights.
+// Note: this message is just a wrapper for input relation.
+message RandomSplit {
+  // (Required) The input relation.
+  Relation input = 1;

Review Comment:
   This method is also possible, but it seems to be somewhat coupled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org