[jira] [Commented] (MESOS-6661) maintenance status page has inconsistent formatting

["Neil Conway (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-6661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712618#comment-15712618 ] 

Neil Conway commented on MESOS-6661:
------------------------------------

The format results from this protobuf definition:

https://github.com/apache/mesos/blob/c33ba209d226fb91874b00976298faf278a29369/include/mesos/maintenance/maintenance.proto#L73

In particular, the {{draining_machines}} list can also include information about inverse offers made for each draining machine.

We could make the {{down_machines}} list more similar to the {{draining_machines}} list (by adding a an "id" key), but I don't think superficial consistency is that important, since the two lists do contain different information.

We might consider always setting the "statuses" key (rather than omitting that key if there are no inverse offers, which might make the asymmetry more obvious.

cc [~kaysoky]

> maintenance status page has inconsistent formatting
> ---------------------------------------------------
>
>                 Key: MESOS-6661
>                 URL: https://issues.apache.org/jira/browse/MESOS-6661
>             Project: Mesos
>          Issue Type: Bug
>          Components: HTTP API
>    Affects Versions: 1.0.1
>         Environment: Mesos Version: 1.01
> OS: Ubuntu 16.04 (both on the client and cluster nodes)
> HTTP Interface: Chrome browser
>            Reporter: Andrew Blanchard
>            Priority: Trivial
>              Labels: formatting, http
>
> *Description*:
> The MachineID lists on the /maintenance/status page are formatted differently. Specifically, with one machine `down` and one machine `draining`, the page is formatted as shown below. Note that the `draining_machines` list has a label ("id") on the machine ID. This formatting extends to multiple items in each respective list.
> {code:xml}
> {
>   "down_machines": [
>     {
>       "hostname": "agent2",
>       "ip": "172.17.0.2"
>     }
>   ],
>   "draining_machines": [
>     {
>       "id": {
>         "hostname": "agent3",
>         "ip": "172.17.0.3"
>       }
>     }
>   ]
> }
> {code}
> *Steps to reproduce*:
> # Add two agents to the maintenance schedule
> # Move one agent to the down state
> # View the status page at <masterIP:port>/maintenance/status
> *Proposed solution*:
> Unify the format. Either way is fine - personally I would prefer them to both be in the current form of `down_machines` with no label on the MachineIDs - but regardless, they should be the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)