You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/15 06:06:34 UTC

[GitHub] [skywalking] codecov-io commented on issue #4363: Fix non-atomic operations on volatile variables

codecov-io commented on issue #4363: Fix non-atomic operations on volatile variables
URL: https://github.com/apache/skywalking/pull/4363#issuecomment-586558394
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4363?src=pr&el=h1) Report
   > Merging [#4363](https://codecov.io/gh/apache/skywalking/pull/4363?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/5fed153ee2c51584a855e474ea97e97c6b8ec9ca?src=pr&el=desc) will **decrease** coverage by `0.17%`.
   > The diff coverage is `60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4363/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4363?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4363      +/-   ##
   ==========================================
   - Coverage   26.14%   25.97%   -0.18%     
   ==========================================
     Files        1182     1181       -1     
     Lines       26922    26841      -81     
     Branches     3714     3702      -12     
   ==========================================
   - Hits         7040     6972      -68     
   + Misses      19248    19239       -9     
   + Partials      634      630       -4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4363?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/4363/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `75% <100%> (+25%)` | :arrow_up: |
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `67.94% <50%> (ø)` | :arrow_up: |
   | [...datacarrier/consumer/MultipleChannelsConsumer.java](https://codecov.io/gh/apache/skywalking/pull/4363/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL011bHRpcGxlQ2hhbm5lbHNDb25zdW1lci5qYXZh) | `10.63% <50%> (+1.94%)` | :arrow_up: |
   | [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4363/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `26.88% <0%> (-1.08%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4363?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4363?src=pr&el=footer). Last update [5fed153...784d53f](https://codecov.io/gh/apache/skywalking/pull/4363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services