You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/21 10:12:32 UTC

[GitHub] [airflow] ephraimbuddy opened a new pull request #21712: Bump jsonschema to 4.4.0,<5.0

ephraimbuddy opened a new pull request #21712:
URL: https://github.com/apache/airflow/pull/21712


   The upper bound is necessary because of connexion upper bound on jsonshema
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ephraimbuddy commented on pull request #21712: Bump jsonschema to 4.4.0,<5.0

Posted by GitBox <gi...@apache.org>.

ephraimbuddy commented on pull request #21712:
URL: https://github.com/apache/airflow/pull/21712#issuecomment-1046709461


   > Why are versions between 3.2.0 and 4.4.0 no longer compatible?
   
   This below:
   ```
   jsonschema.__version__, jsonschema.validators.validators, jsonschema.validators.meta_schemas and jsonschema.RefResolver.in_scope have been deprecated, as has passing a second-argument schema to Validator.iter_errors and Validator.is_valid.
   ```
   Airflow was not directly affected though but I think connexion prevented us from using 4.4.0 until they upgraded jsonschema few days ago


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ephraimbuddy commented on pull request #21712: Bump jsonschema to 4.4.0,<5.0

Posted by GitBox <gi...@apache.org>.

ephraimbuddy commented on pull request #21712:
URL: https://github.com/apache/airflow/pull/21712#issuecomment-1046710293


   Do you suggest we have it as >3.2.0, <5.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #21712: Bump jsonschema to 4.4.0,<5.0

Posted by GitBox <gi...@apache.org>.

uranusjr commented on pull request #21712:
URL: https://github.com/apache/airflow/pull/21712#issuecomment-1046704962


   Why are versions between 3.2.0 and 4.4.0 no longer compatible?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr edited a comment on pull request #21712: Bump jsonschema to 4.4.0,<5.0

Posted by GitBox <gi...@apache.org>.

uranusjr edited a comment on pull request #21712:
URL: https://github.com/apache/airflow/pull/21712#issuecomment-1046711291


   > Do you suggest we have it as >3.2.0, <5.0?
   
   Yes, I was wondering why we need to raise the lower bound. Is 3.2.0 (or _anything before 4.4.0_) no longer compatible, and why? (Because this PR does not change any code, existing code should be compatible with 3.2.0, right?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ephraimbuddy merged pull request #21712: Bump upper bound version of jsonschema to 5.0

Posted by GitBox <gi...@apache.org>.

ephraimbuddy merged pull request #21712:
URL: https://github.com/apache/airflow/pull/21712


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #21712: Bump jsonschema to 4.4.0,<5.0

Posted by GitBox <gi...@apache.org>.

uranusjr commented on pull request #21712:
URL: https://github.com/apache/airflow/pull/21712#issuecomment-1046711291


   Yes, I was wondering why we need to raise the lower bound.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21712: Bump upper bound version of jsonschema to 5.0

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #21712:
URL: https://github.com/apache/airflow/pull/21712#issuecomment-1046753275


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org