You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/19 07:16:41 UTC
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request #4480: Fix migrateVMwithVolumes API in case of VMware to address the case wh…
harikrishna-patnala opened a new pull request #4480:
URL: https://github.com/apache/cloudstack/pull/4480
Problem:
When migrateVMwithVolumes API is tried on a VM with two volumes to migrate to a different host and tried to migrate only one volume, Cloudstack migrates both the Volumes but then marks only one of them migrated. This makes volume inaccessible due to inconsitency in path of volume in cloudstack and vsphere
Solution:
Set the target datastore in relocate spec properly for each volume
Fixes #4421
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [x] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4480: Fix migrateVMwithVolumes API in case of multiple volumes on VMware
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4480:
URL: https://github.com/apache/cloudstack/pull/4480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4480: Fix migrateVMwithVolumes API in case of VMware to address the case wh…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4480:
URL: https://github.com/apache/cloudstack/pull/4480#issuecomment-730722812
<b>Trillian test result (tid-3218)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4480-t3218-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 769.06 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4480: Fix migrateVMwithVolumes API in case of VMware to address the case wh…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4480:
URL: https://github.com/apache/cloudstack/pull/4480#issuecomment-730216960
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4480: Fix migrateVMwithVolumes API in case of VMware to address the case wh…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4480:
URL: https://github.com/apache/cloudstack/pull/4480#issuecomment-730272595
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4480: Fix migrateVMwithVolumes API in case of VMware to address the case wh…
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4480:
URL: https://github.com/apache/cloudstack/pull/4480#issuecomment-730226248
@DaanHoogland This is vmware only issue and is not specific to any storage type.
changes are made only for vmware so we can run tests specific to vmware.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4480: Fix migrateVMwithVolumes API in case of VMware to address the case wh…
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4480:
URL: https://github.com/apache/cloudstack/pull/4480#issuecomment-730217547
@harikrishna-patnala is this a vmware only issue?
And is it specific to certains storage types?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4480: Fix migrateVMwithVolumes API in case of VMware to address the case wh…
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4480:
URL: https://github.com/apache/cloudstack/pull/4480#issuecomment-730272282
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4480: Fix migrateVMwithVolumes API in case of VMware to address the case wh…
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4480:
URL: https://github.com/apache/cloudstack/pull/4480#issuecomment-730216573
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4480: Fix migrateVMwithVolumes API in case of VMware to address the case wh…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4480:
URL: https://github.com/apache/cloudstack/pull/4480#issuecomment-730241431
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org