You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ankita Sinha <an...@freestoneinfotech.com> on 2016/04/21 08:07:04 UTC

Review Request 46476: Add null check for ranger.ks.hsm.enabled property

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46476/
-----------------------------------------------------------

Review request for ranger, Gautam Borad, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-940
    https://issues.apache.org/jira/browse/RANGER-940


Repository: ranger


Description
-------

Ranger KMS server fails to start properly, and is stopping as soon as it starts if ranger.ks.hsm.enabled is null.


Diffs
-----

  kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 12c9ed4 

Diff: https://reviews.apache.org/r/46476/diff/


Testing
-------

1. Tested starting Ranger KMS with by removing ranger.ks.hsm.enabled property from xml configuration.
2. Tested the basic Key operation commands.


Thanks,

Ankita Sinha


Re: Review Request 46476: Add null check for ranger.ks.hsm.enabled property

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46476/#review129860
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On April 21, 2016, 6:07 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46476/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 6:07 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-940
>     https://issues.apache.org/jira/browse/RANGER-940
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger KMS server fails to start properly, and is stopping as soon as it starts if ranger.ks.hsm.enabled is null.
> 
> 
> Diffs
> -----
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 12c9ed4 
> 
> Diff: https://reviews.apache.org/r/46476/diff/
> 
> 
> Testing
> -------
> 
> 1. Tested starting Ranger KMS with by removing ranger.ks.hsm.enabled property from xml configuration.
> 2. Tested the basic Key operation commands.
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>