[GitHub] [arrow-rs] HaoYang670 opened a new issue, #1747: Rename the `string` kernel as `concatenate_elements`

[GitBox <gi...@apache.org>]

HaoYang670 opened a new issue, #1747:
URL: https://github.com/apache/arrow-rs/issues/1747

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   This is a follow-up of #1720.
   We have added `concatenate by elements` support for string array and put it into the new created `string` kernel.
   I suggest we should rename the kernel `concatenate_elements`.
   
   There are some reasons I thought why `concatenate_elements` is better than `string`:
   1. The name of the compute kernel should express what kind of operation will be done on an array, such as `cast`, `aggregate` ...
   2. We can support the `concatenate_elements` operation on binary array, list array and other nested types. So `string` is not an appropriate name.
   3. In cudf (which is based on Arrow c++, and more GPU supported), there are similar kernels and we can refer to their names.: https://github.com/rapidsai/cudf/blob/branch-22.08/cpp/src/lists/combine/concatenate_list_elements.cu
   https://github.com/rapidsai/cudf/blob/branch-22.08/cpp/src/lists/combine/concatenate_rows.cu
   
   **Describe the solution you'd like**
   A clear and concise description of what you want to happen.
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb closed issue #1747: Rename the `string` kernel to `concatenate_elements`

[GitBox <gi...@apache.org>]

alamb closed issue #1747: Rename the `string` kernel to `concatenate_elements`
URL: https://github.com/apache/arrow-rs/issues/1747


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on issue #1747: Rename the `string` kernel as `concatenate_elements`

[GitBox <gi...@apache.org>]

alamb commented on issue #1747:
URL: https://github.com/apache/arrow-rs/issues/1747#issuecomment-1138370679

   Hi @HaoYang670 
   > I suggest we should rename the kernel concatenate_elements.
   
   If you mean rename `arrow/src/compute/kernels/string.rs` to ``arrow/src/compute/kernels/concat_elements.rs` I think it is a great idea (and ideally we could do it in the next day or two before we released arrow 15 avoiding a breaking change in a released version)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] HaoYang670 commented on issue #1747: Rename the `string` kernel as `concatenate_elements`

[GitBox <gi...@apache.org>]

HaoYang670 commented on issue #1747:
URL: https://github.com/apache/arrow-rs/issues/1747#issuecomment-1138057180

   cc @alamb @tustvold @viirya. Looking forward to your opinions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org