You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Bukama (via GitHub)" <gi...@apache.org> on 2026/05/12 16:56:03 UTC
[PR] Enable regular workflow and Maven 4 build [maven-jlink-plugin]
Bukama opened a new pull request, #671:
URL: https://github.com/apache/maven-jlink-plugin/pull/671
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable regular workflow and Maven 4 build [maven-jlink-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #671:
URL: https://github.com/apache/maven-jlink-plugin/pull/671#discussion_r3228356871
##########
.github/workflows/maven-verify.yml:
##########
@@ -15,36 +15,16 @@
# specific language governing permissions and limitations
# under the License.
-name: Java CI
+name: Verify
-on: [ push, pull_request ]
+on:
+ push:
+ pull_request:
jobs:
build:
-
- strategy:
- matrix:
- os: [ ubuntu-latest, windows-latest, macOS-latest ]
- java: [ 11, 17, 21 ]
- dist: [ 'temurin', 'semeru' ]
- exclude:
- - os: macos-latest
- dist: 'semeru'
-
- fail-fast: false
-
- runs-on: ${{ matrix.os }}
-
- steps:
- - name: Checkout
- uses: actions/checkout@v6
-
- - name: Set up JDK
- uses: actions/setup-java@v5
- with:
- distribution: ${{ matrix.dist }}
- java-version: ${{ matrix.java }}
- cache: 'maven'
-
- - name: Build with Maven
- run: mvn verify --errors --batch-mode --show-version -Prun-its
+ name: Verify
+ uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4
+ with:
+ maven4-enabled: 'true'
+ jdk-distribution-matrix: '[ "temurin", "semeru"]'
Review Comment:
we need to exclude jdk8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable regular workflow and Maven 4 build [maven-jlink-plugin]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #671:
URL: https://github.com/apache/maven-jlink-plugin/pull/671#issuecomment-4480666320
```
D:\Github\Maven\maven-jmod-plugin>mvn --version
Apache Maven 4.0.0-rc-5 (fb3ecaef88106acb40467a450248dfdbd75f3b35)
Maven home: C:\apache-maven-4.0.0-rc-5
Java version: 25.0.2, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-25
Default locale: de_DE, platform encoding: UTF-8
OS name: "windows 11", version: "10.0", arch: "amd64", family: "winnt"
[ERROR] The following builds failed:
[ERROR] * cli-options\endian-big\pom.xml
```
Error is an invalid jlink (`--endian` in combination with `big`) argument.
```
[DEBUG] Adding artifact: localhost:first-jar-module-info:99.0
[INFO] -> module: first.jar.module.info ( D:\Github\Maven\maven-jlink-plugin\target\local-repo\localhost\first-jar-module-info\99.0\first-jar-module-info-99.0.jar )
[DEBUG] jlink [--endian, big, --module-path, D:\\Github\\Maven\\maven-jlink-plugin\\target\\local-repo\\localhost\\first-jar-module-info\\99.0\\first-jar-module-info-99.0.jar, --add-modules, first.jar.module.info, --output, D:\Github\Maven\maven-jlink-plugin\target\it\cli-options\endian-big\target\maven-jlink\default]
[ERROR]
[ERROR] Fehler: Die angegebene Option --endian BIG_ENDIAN entspricht nicht dem Endian-Typ der Zielplattform windows-x64
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.252 s
[INFO] Finished at: 2026-05-18T20:16:05+02:00
[INFO] ------------------------------------------------------------------------
```
(according to AI) It needs to be `little` on Windows or skipped at all (like in IT `cli-options\endian`), so jlink chooses what fits for the machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable regular workflow and Maven 4 build [maven-jlink-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #671:
URL: https://github.com/apache/maven-jlink-plugin/pull/671#discussion_r3624183079
##########
.github/workflows/maven-verify.yml:
##########
@@ -21,6 +21,8 @@ on: [ push, pull_request ]
jobs:
build:
+ with:
+ maven4-enabled: true
Review Comment:
looks like parameters for shared-actions ... but shared-actions is not used ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable regular workflow and Maven 4 build [maven-jlink-plugin]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #671:
URL: https://github.com/apache/maven-jlink-plugin/pull/671#issuecomment-4474312460
Note: This PR is for checking build status for Maven 4.0.0 according to checklist https://cwiki.apache.org/confluence/display/MAVEN/Maven+4.0.0+GA+checklist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable regular workflow and Maven 4 build [maven-jlink-plugin]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #671:
URL: https://github.com/apache/maven-jlink-plugin/pull/671#discussion_r3228525189
##########
.github/workflows/maven-verify.yml:
##########
@@ -15,36 +15,16 @@
# specific language governing permissions and limitations
# under the License.
-name: Java CI
+name: Verify
-on: [ push, pull_request ]
+on:
+ push:
+ pull_request:
jobs:
build:
-
- strategy:
- matrix:
- os: [ ubuntu-latest, windows-latest, macOS-latest ]
- java: [ 11, 17, 21 ]
- dist: [ 'temurin', 'semeru' ]
- exclude:
- - os: macos-latest
- dist: 'semeru'
-
- fail-fast: false
-
- runs-on: ${{ matrix.os }}
-
- steps:
- - name: Checkout
- uses: actions/checkout@v6
-
- - name: Set up JDK
- uses: actions/setup-java@v5
- with:
- distribution: ${{ matrix.dist }}
- java-version: ${{ matrix.java }}
- cache: 'maven'
-
- - name: Build with Maven
- run: mvn verify --errors --batch-mode --show-version -Prun-its
+ name: Verify
+ uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4
+ with:
+ maven4-enabled: 'true'
+ jdk-distribution-matrix: '[ "temurin", "semeru"]'
Review Comment:
Hope this is correct. The example from the Shared-GH-Actions-Doc gave me syntax error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable regular workflow and Maven 4 build [maven-jlink-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #671:
URL: https://github.com/apache/maven-jlink-plugin/pull/671#discussion_r3228541442
##########
.github/workflows/maven-verify.yml:
##########
@@ -15,36 +15,21 @@
# specific language governing permissions and limitations
# under the License.
-name: Java CI
+name: Verify
-on: [ push, pull_request ]
+on:
+ push:
+ pull_request:
jobs:
build:
+ name: Verify
+ uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4
+ with:
+ maven4-enabled: 'true'
Review Comment:
to fix:
```suggestion
maven4-enabled: true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable regular workflow and Maven 4 build [maven-jlink-plugin]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #671:
URL: https://github.com/apache/maven-jlink-plugin/pull/671#issuecomment-4586187614
```
[ERROR] Fehler: Die angegebene Option --endian BIG_ENDIAN entspricht nicht dem Endian-Typ der Zielplattform windows-x64
```
is https://github.com/apache/maven-jlink-plugin/issues/675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org