You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2022/12/18 15:55:00 UTC

[jira] [Commented] (MNG-7352) org.apache.maven.toolchain.java.JavaToolchainImpl should be public

    [ https://issues.apache.org/jira/browse/MNG-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649048#comment-17649048 ] 

Michael Osipov commented on MNG-7352:
-------------------------------------

Look at 61f1d01ba86e0765e0a78eb0b18571ee503055f6. [~hboutemy], well this class was public, you assumed it should be package private, though the deprecated one does not provide a public successor. I am included to make this public again. WDYT?

> org.apache.maven.toolchain.java.JavaToolchainImpl should be public
> ------------------------------------------------------------------
>
>                 Key: MNG-7352
>                 URL: https://issues.apache.org/jira/browse/MNG-7352
>             Project: Maven
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.8.4
>            Reporter: Michael Keppler
>            Priority: Trivial
>
> org.apache.maven.toolchain.java.JavaToolchainImpl has been created as replacement for the now deprecated org.apache.maven.toolchain.java.DefaultJavaToolChain.
> However, the deprecated class was public, the new one isn't. That makes it impossible to follow the deprecation note to use the new class (outside of Maven core). I'm trying to fix this deprecation in Maven Tycho.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)