You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/06/04 19:29:10 UTC
[GitHub] [openwhisk] mcdan opened a new pull request #4915: Add the ability to limit the amount of disk given to the action pod in k8s
mcdan opened a new pull request #4915:
URL: https://github.com/apache/openwhisk/pull/4915
<!--- Provide a concise summary of your changes in the Title -->
## Description
<!--- Provide a detailed description of your changes. -->
This will allow the deployment to limit the total amount of ephemeral disk given to a pod when it's created. This prevents an attacker from overwhelming the node with disk writes.
<!--- Include details of what problem you are solving and how your changes are tested. -->
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [x] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [x] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [x] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] mcdan commented on a change in pull request #4915: Add the ability to limit the amount of disk given to the action pod in k8s
Posted by GitBox <gi...@apache.org>.
mcdan commented on a change in pull request #4915:
URL: https://github.com/apache/openwhisk/pull/4915#discussion_r435511284
##########
File path: core/invoker/src/main/resources/application.conf
##########
@@ -107,6 +107,14 @@ whisk {
# "POD_UID": "metadata.uid"
#}
+ #if missing, the pod will be created without ephermal disk request/limit
+ #if specified, the pod will be created with ephemeral-storage request+limit set
+ #See: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#local-ephemeral-storage
+ #ephemeral-storage {
+ # limit = 2 g
+ # request = 500 m
Review comment:
That's a good point, I will limit the configuration to just a limit and set the request to the same value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-commenter commented on pull request #4915: Add the ability to limit the amount of disk given to the action pod in k8s
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #4915:
URL: https://github.com/apache/openwhisk/pull/4915#issuecomment-641562044
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=h1) Report
> Merging [#4915](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/8759cadeea6101a3693aac1d34d4069f516d5558&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4915 +/- ##
==========================================
+ Coverage 83.42% 83.51% +0.08%
==========================================
Files 201 201
Lines 9517 9520 +3
Branches 392 400 +8
==========================================
+ Hits 7940 7951 +11
+ Misses 1577 1569 -8
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...re/containerpool/kubernetes/KubernetesClient.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDbGllbnQuc2NhbGE=) | `20.90% <ø> (ø)` | |
| [...ore/containerpool/kubernetes/WhiskPodBuilder.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL1doaXNrUG9kQnVpbGRlci5zY2FsYQ==) | `95.00% <100.00%> (+0.26%)` | :arrow_up: |
| [.../org/apache/openwhisk/common/NestedSemaphore.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9OZXN0ZWRTZW1hcGhvcmUuc2NhbGE=) | `84.84% <0.00%> (-3.04%)` | :arrow_down: |
| [...e/openwhisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `97.89% <0.00%> (+<0.01%)` | :arrow_up: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `96.60% <0.00%> (+0.37%)` | :arrow_up: |
| [.../org/apache/openwhisk/core/connector/Message.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `80.15% <0.00%> (+1.58%)` | :arrow_up: |
| [.../scala/org/apache/openwhisk/core/entity/Size.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=) | `79.10% <0.00%> (+2.98%)` | :arrow_up: |
| [...core/database/cosmosdb/RetryMetricsCollector.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUmV0cnlNZXRyaWNzQ29sbGVjdG9yLnNjYWxh) | `85.71% <0.00%> (+4.76%)` | :arrow_up: |
| [...rg/apache/openwhisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `96.15% <0.00%> (+7.69%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=footer). Last update [8759cad...039780b](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #4915: Add the ability to limit the amount of disk given to the action pod in k8s
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #4915:
URL: https://github.com/apache/openwhisk/pull/4915#issuecomment-641562044
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=h1) Report
> Merging [#4915](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/8759cadeea6101a3693aac1d34d4069f516d5558&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4915 +/- ##
==========================================
+ Coverage 83.42% 83.51% +0.08%
==========================================
Files 201 201
Lines 9517 9520 +3
Branches 392 400 +8
==========================================
+ Hits 7940 7951 +11
+ Misses 1577 1569 -8
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...re/containerpool/kubernetes/KubernetesClient.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDbGllbnQuc2NhbGE=) | `20.90% <ø> (ø)` | |
| [...ore/containerpool/kubernetes/WhiskPodBuilder.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL1doaXNrUG9kQnVpbGRlci5zY2FsYQ==) | `95.00% <100.00%> (+0.26%)` | :arrow_up: |
| [.../org/apache/openwhisk/common/NestedSemaphore.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9OZXN0ZWRTZW1hcGhvcmUuc2NhbGE=) | `84.84% <0.00%> (-3.04%)` | :arrow_down: |
| [...e/openwhisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `97.89% <0.00%> (+<0.01%)` | :arrow_up: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `96.60% <0.00%> (+0.37%)` | :arrow_up: |
| [.../org/apache/openwhisk/core/connector/Message.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `80.15% <0.00%> (+1.58%)` | :arrow_up: |
| [.../scala/org/apache/openwhisk/core/entity/Size.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=) | `79.10% <0.00%> (+2.98%)` | :arrow_up: |
| [...core/database/cosmosdb/RetryMetricsCollector.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUmV0cnlNZXRyaWNzQ29sbGVjdG9yLnNjYWxh) | `85.71% <0.00%> (+4.76%)` | :arrow_up: |
| [...rg/apache/openwhisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `96.15% <0.00%> (+7.69%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=footer). Last update [8759cad...039780b](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] mcdan merged pull request #4915: Add the ability to limit the amount of disk given to the action pod in k8s
Posted by GitBox <gi...@apache.org>.
mcdan merged pull request #4915:
URL: https://github.com/apache/openwhisk/pull/4915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-commenter edited a comment on pull request #4915: Add the ability to limit the amount of disk given to the action pod in k8s
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #4915:
URL: https://github.com/apache/openwhisk/pull/4915#issuecomment-641562044
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=h1) Report
> Merging [#4915](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/8759cadeea6101a3693aac1d34d4069f516d5558&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4915 +/- ##
==========================================
+ Coverage 83.42% 83.51% +0.08%
==========================================
Files 201 201
Lines 9517 9520 +3
Branches 392 400 +8
==========================================
+ Hits 7940 7951 +11
+ Misses 1577 1569 -8
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...re/containerpool/kubernetes/KubernetesClient.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDbGllbnQuc2NhbGE=) | `20.90% <ø> (ø)` | |
| [...ore/containerpool/kubernetes/WhiskPodBuilder.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL1doaXNrUG9kQnVpbGRlci5zY2FsYQ==) | `95.00% <100.00%> (+0.26%)` | :arrow_up: |
| [.../org/apache/openwhisk/common/NestedSemaphore.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9OZXN0ZWRTZW1hcGhvcmUuc2NhbGE=) | `84.84% <0.00%> (-3.04%)` | :arrow_down: |
| [...e/openwhisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `97.89% <0.00%> (+<0.01%)` | :arrow_up: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `96.60% <0.00%> (+0.37%)` | :arrow_up: |
| [.../org/apache/openwhisk/core/connector/Message.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `80.15% <0.00%> (+1.58%)` | :arrow_up: |
| [.../scala/org/apache/openwhisk/core/entity/Size.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=) | `79.10% <0.00%> (+2.98%)` | :arrow_up: |
| [...core/database/cosmosdb/RetryMetricsCollector.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUmV0cnlNZXRyaWNzQ29sbGVjdG9yLnNjYWxh) | `85.71% <0.00%> (+4.76%)` | :arrow_up: |
| [...rg/apache/openwhisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/openwhisk/pull/4915/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `96.15% <0.00%> (+7.69%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=footer). Last update [8759cad...039780b](https://codecov.io/gh/apache/openwhisk/pull/4915?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] tysonnorris commented on a change in pull request #4915: Add the ability to limit the amount of disk given to the action pod in k8s
Posted by GitBox <gi...@apache.org>.
tysonnorris commented on a change in pull request #4915:
URL: https://github.com/apache/openwhisk/pull/4915#discussion_r435506715
##########
File path: core/invoker/src/main/resources/application.conf
##########
@@ -107,6 +107,14 @@ whisk {
# "POD_UID": "metadata.uid"
#}
+ #if missing, the pod will be created without ephermal disk request/limit
+ #if specified, the pod will be created with ephemeral-storage request+limit set
+ #See: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#local-ephemeral-storage
+ #ephemeral-storage {
+ # limit = 2 g
+ # request = 500 m
Review comment:
I know these are defaults, but It seems like a risk to have different limit and request, if exceeding the request but not the limit might cause the pod to terminate or be evicted. I can't tell from the docs if this is the case for ephemeral storage, but docs indicate it is the case e.g. for memory. Since there is currently no recovery from user-action pods that terminate due to kubernetes events despite valid configurations from OW and kubernetes point of view, it might be safer to keep these values the same. If there is no extra risk of termination, of course they can be different, I just don't know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org