You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/15 00:24:03 UTC

[GitHub] [incubator-mxnet] leezu opened a new pull request #19143: Fix legacy codepath detection feature for decorated HybridBlocks

leezu opened a new pull request #19143:
URL: https://github.com/apache/incubator-mxnet/pull/19143


   `if self.hybrid_forward.__func__ is not HybridBlock.hybrid_forward` check for detecting legacy Blocks yields false positives on Gluon 2 Blocks if they are wrapped with a class decorator. This leads to hybridization to silently fail on Gluon 2 Blocks that make use of class decorator such as `@use_np`.
   
   Fix by using `inspect.unwrap`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu merged pull request #19143: Fix legacy codepath detection feature for decorated HybridBlocks

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19143:
URL: https://github.com/apache/incubator-mxnet/pull/19143


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19143: Fix legacy codepath detection feature for decorated HybridBlocks

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19143:
URL: https://github.com/apache/incubator-mxnet/pull/19143#issuecomment-692387196


   Hey @leezu , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [website, edge, clang, windows-gpu, unix-cpu, sanity, centos-cpu, centos-gpu, windows-cpu, unix-gpu, miscellaneous]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org