You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Sean Schofield <se...@gmail.com> on 2005/07/25 19:21:48 UTC
Problem with HtmlImageRendererBase
I noticed that UIGraphic components are no longer having their id's
rendered in the HTML. This is causing a problem with Tree2. Martin,
can you shed some light on the changes you made to this class? Is
writing the id a problem with the spec or is it something that
accidentally got lost?
Regards,
sean
Re: Problem with HtmlImageRendererBase
Posted by Bruno Aranda <br...@gmail.com>.
You're welcome, Sean. Thanks for your kind words :-)
Best regards,
Bruno
2005/7/25, Sean Schofield <se...@gmail.com>:
> Yeah that works. Good idea. I guess in the future we'll need to keep
> in mind that autogenerated ids aren't going to be rendered unless you
> provide your own special prefix.
>
> Thanks
>
> sean
>
> ps. Nice work on all of the JIRA resolutions you and Mathias have been
> providing lately.
>
>
> On 7/25/05, Bruno Aranda <br...@gmail.com> wrote:
> > You could try to add an own prefix to the image created dynamically so
> > writeIdIfNecessary does render the id, couldn't you?
> >
> > Bruno
> >
> > 2005/7/25, Sean Schofield <se...@gmail.com>:
> > > Its definitely the writeIdIfNecessary (I was just looking up the svn
> > > blame to find the culprit when I read your message.)
> > >
> > > I can see why in *most* cases we don't want to render an id unless one
> > > was explicitly provided. In the tree2 case though we are creating
> > > components dynamically and they need ids that can be refrenced via
> > > javascript.
> > >
> > > sean
> > >
> > > On 7/25/05, Bruno Aranda <br...@gmail.com> wrote:
> > > > I am the one who provided the patch to extend the graphicImage
> > > > component. As far as I recall I only put in HtmlImageRendererBase the
> > > > code that was in the HtmlImageRenderer class. So I am not sure what is
> > > > happening now. Maybe an issue with
> > > > HtmlRendererUtils.writeIdIfNecessary....
> > > >
> > > > Bruno
> > > >
> > > > 2005/7/25, Sean Schofield <se...@gmail.com>:
> > > > > I noticed that UIGraphic components are no longer having their id's
> > > > > rendered in the HTML. This is causing a problem with Tree2. Martin,
> > > > > can you shed some light on the changes you made to this class? Is
> > > > > writing the id a problem with the spec or is it something that
> > > > > accidentally got lost?
> > > > >
> > > > > Regards,
> > > > >
> > > > > sean
> > > > >
> > > >
> > >
> >
>
Re: Problem with HtmlImageRendererBase
Posted by Sean Schofield <se...@gmail.com>.
Yeah that works. Good idea. I guess in the future we'll need to keep
in mind that autogenerated ids aren't going to be rendered unless you
provide your own special prefix.
Thanks
sean
ps. Nice work on all of the JIRA resolutions you and Mathias have been
providing lately.
On 7/25/05, Bruno Aranda <br...@gmail.com> wrote:
> You could try to add an own prefix to the image created dynamically so
> writeIdIfNecessary does render the id, couldn't you?
>
> Bruno
>
> 2005/7/25, Sean Schofield <se...@gmail.com>:
> > Its definitely the writeIdIfNecessary (I was just looking up the svn
> > blame to find the culprit when I read your message.)
> >
> > I can see why in *most* cases we don't want to render an id unless one
> > was explicitly provided. In the tree2 case though we are creating
> > components dynamically and they need ids that can be refrenced via
> > javascript.
> >
> > sean
> >
> > On 7/25/05, Bruno Aranda <br...@gmail.com> wrote:
> > > I am the one who provided the patch to extend the graphicImage
> > > component. As far as I recall I only put in HtmlImageRendererBase the
> > > code that was in the HtmlImageRenderer class. So I am not sure what is
> > > happening now. Maybe an issue with
> > > HtmlRendererUtils.writeIdIfNecessary....
> > >
> > > Bruno
> > >
> > > 2005/7/25, Sean Schofield <se...@gmail.com>:
> > > > I noticed that UIGraphic components are no longer having their id's
> > > > rendered in the HTML. This is causing a problem with Tree2. Martin,
> > > > can you shed some light on the changes you made to this class? Is
> > > > writing the id a problem with the spec or is it something that
> > > > accidentally got lost?
> > > >
> > > > Regards,
> > > >
> > > > sean
> > > >
> > >
> >
>
Re: Problem with HtmlImageRendererBase
Posted by Bruno Aranda <br...@gmail.com>.
You could try to add an own prefix to the image created dynamically so
writeIdIfNecessary does render the id, couldn't you?
Bruno
2005/7/25, Sean Schofield <se...@gmail.com>:
> Its definitely the writeIdIfNecessary (I was just looking up the svn
> blame to find the culprit when I read your message.)
>
> I can see why in *most* cases we don't want to render an id unless one
> was explicitly provided. In the tree2 case though we are creating
> components dynamically and they need ids that can be refrenced via
> javascript.
>
> sean
>
> On 7/25/05, Bruno Aranda <br...@gmail.com> wrote:
> > I am the one who provided the patch to extend the graphicImage
> > component. As far as I recall I only put in HtmlImageRendererBase the
> > code that was in the HtmlImageRenderer class. So I am not sure what is
> > happening now. Maybe an issue with
> > HtmlRendererUtils.writeIdIfNecessary....
> >
> > Bruno
> >
> > 2005/7/25, Sean Schofield <se...@gmail.com>:
> > > I noticed that UIGraphic components are no longer having their id's
> > > rendered in the HTML. This is causing a problem with Tree2. Martin,
> > > can you shed some light on the changes you made to this class? Is
> > > writing the id a problem with the spec or is it something that
> > > accidentally got lost?
> > >
> > > Regards,
> > >
> > > sean
> > >
> >
>
Re: Problem with HtmlImageRendererBase
Posted by Sean Schofield <se...@gmail.com>.
Its definitely the writeIdIfNecessary (I was just looking up the svn
blame to find the culprit when I read your message.)
I can see why in *most* cases we don't want to render an id unless one
was explicitly provided. In the tree2 case though we are creating
components dynamically and they need ids that can be refrenced via
javascript.
sean
On 7/25/05, Bruno Aranda <br...@gmail.com> wrote:
> I am the one who provided the patch to extend the graphicImage
> component. As far as I recall I only put in HtmlImageRendererBase the
> code that was in the HtmlImageRenderer class. So I am not sure what is
> happening now. Maybe an issue with
> HtmlRendererUtils.writeIdIfNecessary....
>
> Bruno
>
> 2005/7/25, Sean Schofield <se...@gmail.com>:
> > I noticed that UIGraphic components are no longer having their id's
> > rendered in the HTML. This is causing a problem with Tree2. Martin,
> > can you shed some light on the changes you made to this class? Is
> > writing the id a problem with the spec or is it something that
> > accidentally got lost?
> >
> > Regards,
> >
> > sean
> >
>
Re: Problem with HtmlImageRendererBase
Posted by Bruno Aranda <br...@gmail.com>.
I am the one who provided the patch to extend the graphicImage
component. As far as I recall I only put in HtmlImageRendererBase the
code that was in the HtmlImageRenderer class. So I am not sure what is
happening now. Maybe an issue with
HtmlRendererUtils.writeIdIfNecessary....
Bruno
2005/7/25, Sean Schofield <se...@gmail.com>:
> I noticed that UIGraphic components are no longer having their id's
> rendered in the HTML. This is causing a problem with Tree2. Martin,
> can you shed some light on the changes you made to this class? Is
> writing the id a problem with the spec or is it something that
> accidentally got lost?
>
> Regards,
>
> sean
>