You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airavata.apache.org by Viknes B <vi...@msn.com> on 2013/06/18 19:37:33 UTC

Review Request: Enabling CORS support in Airavata Server

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11941/
-----------------------------------------------------------

Review request for Airavata.


Description
-------

Adding a CORS filter for Airavata server


This addresses bug Airavata-870.
    https://issues.apache.org/jira/browse/Airavata-870


Diffs
-----

  trunk/modules/distribution/airavata-server/pom.xml 1493972 
  trunk/modules/distribution/airavata-server/src/main/assembly/bin-assembly.xml 1493972 
  trunk/modules/rest/webapp/pom.xml 1493972 
  trunk/modules/rest/webapp/src/main/webapp/WEB-INF/web.xml 1493972 
  trunk/modules/server/pom.xml 1493972 
  trunk/modules/server/src/main/java/org/apache/airavata/server/ServerMain.java 1493972 
  trunk/pom.xml 1493972 

Diff: https://reviews.apache.org/r/11941/diff/


Testing
-------


Thanks,

Viknes B


Re: Review Request 11941: Enabling CORS support in Airavata Server

Posted by Suresh Marru <sm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11941/#review25132
-----------------------------------------------------------


Amila, can you please review this?

- Suresh Marru


On June 18, 2013, 5:37 p.m., Viknes Balasubramanee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11941/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 5:37 p.m.)
> 
> 
> Review request for Airavata.
> 
> 
> Bugs: Airavata-870
>     https://issues.apache.org/jira/browse/Airavata-870
> 
> 
> Repository: Airavata
> 
> 
> Description
> -------
> 
> Adding a CORS filter for Airavata server
> 
> 
> Diffs
> -----
> 
>   trunk/modules/distribution/airavata-server/pom.xml 1493972 
>   trunk/modules/distribution/airavata-server/src/main/assembly/bin-assembly.xml 1493972 
>   trunk/modules/rest/webapp/pom.xml 1493972 
>   trunk/modules/rest/webapp/src/main/webapp/WEB-INF/web.xml 1493972 
>   trunk/modules/server/pom.xml 1493972 
>   trunk/modules/server/src/main/java/org/apache/airavata/server/ServerMain.java 1493972 
>   trunk/pom.xml 1493972 
> 
> Diff: https://reviews.apache.org/r/11941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Viknes Balasubramanee
> 
>


Re: Review Request: Enabling CORS support in Airavata Server

Posted by Suresh Marru <sm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11941/#review22066
-----------------------------------------------------------


Thanks Viknes for the contribution. The patch looks good to me, but I am not an expert on this and will let Amila and others knowledgeable on the topic review and accept. The license of the filter is ASF V2, so no huddles there. 

- Suresh Marru


On June 18, 2013, 5:37 p.m., Viknes B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11941/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 5:37 p.m.)
> 
> 
> Review request for Airavata.
> 
> 
> Description
> -------
> 
> Adding a CORS filter for Airavata server
> 
> 
> This addresses bug Airavata-870.
>     https://issues.apache.org/jira/browse/Airavata-870
> 
> 
> Diffs
> -----
> 
>   trunk/modules/distribution/airavata-server/pom.xml 1493972 
>   trunk/modules/distribution/airavata-server/src/main/assembly/bin-assembly.xml 1493972 
>   trunk/modules/rest/webapp/pom.xml 1493972 
>   trunk/modules/rest/webapp/src/main/webapp/WEB-INF/web.xml 1493972 
>   trunk/modules/server/pom.xml 1493972 
>   trunk/modules/server/src/main/java/org/apache/airavata/server/ServerMain.java 1493972 
>   trunk/pom.xml 1493972 
> 
> Diff: https://reviews.apache.org/r/11941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Viknes B
> 
>


Re: Review Request 11941: Enabling CORS support in Airavata Server

Posted by chathuri wimalasena <ka...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11941/#review26389
-----------------------------------------------------------

Ship it!


Ship It!

- chathuri wimalasena


On June 18, 2013, 5:37 p.m., Viknes Balasubramanee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11941/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 5:37 p.m.)
> 
> 
> Review request for Airavata.
> 
> 
> Bugs: Airavata-870
>     https://issues.apache.org/jira/browse/Airavata-870
> 
> 
> Repository: Airavata
> 
> 
> Description
> -------
> 
> Adding a CORS filter for Airavata server
> 
> 
> Diffs
> -----
> 
>   trunk/modules/distribution/airavata-server/pom.xml 1493972 
>   trunk/modules/distribution/airavata-server/src/main/assembly/bin-assembly.xml 1493972 
>   trunk/modules/rest/webapp/pom.xml 1493972 
>   trunk/modules/rest/webapp/src/main/webapp/WEB-INF/web.xml 1493972 
>   trunk/modules/server/pom.xml 1493972 
>   trunk/modules/server/src/main/java/org/apache/airavata/server/ServerMain.java 1493972 
>   trunk/pom.xml 1493972 
> 
> Diff: https://reviews.apache.org/r/11941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Viknes Balasubramanee
> 
>


Re: Review Request: Enabling CORS support in Airavata Server

Posted by Viknes B <vi...@msn.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11941/
-----------------------------------------------------------

(Updated June 18, 2013, 5:37 p.m.)


Review request for Airavata.


Description
-------

Adding a CORS filter for Airavata server


This addresses bug Airavata-870.
    https://issues.apache.org/jira/browse/Airavata-870


Diffs
-----

  trunk/modules/distribution/airavata-server/pom.xml 1493972 
  trunk/modules/distribution/airavata-server/src/main/assembly/bin-assembly.xml 1493972 
  trunk/modules/rest/webapp/pom.xml 1493972 
  trunk/modules/rest/webapp/src/main/webapp/WEB-INF/web.xml 1493972 
  trunk/modules/server/pom.xml 1493972 
  trunk/modules/server/src/main/java/org/apache/airavata/server/ServerMain.java 1493972 
  trunk/pom.xml 1493972 

Diff: https://reviews.apache.org/r/11941/diff/


Testing
-------


Thanks,

Viknes B