You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by "ivila (via GitHub)" <gi...@apache.org> on 2024/10/25 06:18:04 UTC
[PR] no-std: optee-utee: make panic_handler optional [incubator-teaclave-trustzone-sdk]
ivila opened a new pull request, #147:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/147
Make panic_handler optional for no-std TAs by adding "no_panic_handler" feature flag. It allows no-std TAs to have a custom panic handler.
Relative issue is here: #145
This PR is a recreate one, the former PR was closed due to using the wrong branch(as metioned in #143 , the only maintenance branch should be main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
Re: [PR] no-std: optee-utee: make panic_handler optional [incubator-teaclave-trustzone-sdk]
Posted by "DemesneGH (via GitHub)" <gi...@apache.org>.
DemesneGH commented on PR #147:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/147#issuecomment-2437492964
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
Re: [PR] no-std: optee-utee: make panic_handler optional [incubator-teaclave-trustzone-sdk]
Posted by "DemesneGH (via GitHub)" <gi...@apache.org>.
DemesneGH merged PR #147:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
Re: [PR] no-std: optee-utee: make panic_handler optional [incubator-teaclave-trustzone-sdk]
Posted by "DemesneGH (via GitHub)" <gi...@apache.org>.
DemesneGH commented on PR #147:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/147#issuecomment-2437012562
LGTM. @b49020 any comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
Re: [PR] no-std: optee-utee: make panic_handler optional [incubator-teaclave-trustzone-sdk]
Posted by "ivila (via GitHub)" <gi...@apache.org>.
ivila commented on PR #147:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/147#issuecomment-2437488285
Sorry for late reply, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
Re: [PR] no-std: optee-utee: make panic_handler optional [incubator-teaclave-trustzone-sdk]
Posted by "DemesneGH (via GitHub)" <gi...@apache.org>.
DemesneGH commented on code in PR #147:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/147#discussion_r1816073903
##########
optee-utee/src/lib.rs:
##########
@@ -35,6 +35,7 @@ use core::panic::PanicInfo;
use optee_utee_sys as raw;
#[cfg(not(target_os = "optee"))]
+#[cfg(not(feature = "no_panic_handler"))]
Review Comment:
merge the two condition into `#[cfg(all(not(target_os = "optee"), not(feature = "no_panic_handler")))]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
Re: [PR] no-std: optee-utee: make panic_handler optional [incubator-teaclave-trustzone-sdk]
Posted by "DemesneGH (via GitHub)" <gi...@apache.org>.
DemesneGH commented on PR #147:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/147#issuecomment-2437426414
Ready to merge, please squash the commits into one and append the tags in commit message:
```
Signed-off-by: [YOUR NAME] <YOUR_EMAIL>
Reviewed-by: Sumit Garg <su...@linaro.org>
Reviewed-by: Yuan Zhuang <yu...@apache.org>
```
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
Re: [PR] no-std: optee-utee: make panic_handler optional [incubator-teaclave-trustzone-sdk]
Posted by "b49020 (via GitHub)" <gi...@apache.org>.
b49020 commented on PR #147:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/147#issuecomment-2437050714
With the patches squashed, feel free to add:
`Reviewed-by: Sumit Garg <su...@linaro.org>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org