You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/15 21:14:21 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7516: feat:
Live query validation in the SQL Lab UI (#7461)
codecov-io commented on issue #7516: feat: Live query validation in the SQL Lab UI (#7461)
URL: https://github.com/apache/incubator-superset/pull/7516#issuecomment-492826329
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7516?src=pr&el=h1) Report
> Merging [#7516](https://codecov.io/gh/apache/incubator-superset/pull/7516?src=pr&el=desc) into [lyft-develop](https://codecov.io/gh/apache/incubator-superset/commit/fda10026548169b507a2ccad3049bd3305c7978b?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `17.91%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## lyft-develop #7516 +/- ##
================================================
- Coverage 65.43% 65.29% -0.15%
================================================
Files 432 432
Lines 21319 21386 +67
Branches 2347 2357 +10
================================================
+ Hits 13951 13963 +12
- Misses 7252 7303 +51
- Partials 116 120 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7516?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset/assets/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/7516/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <ø> (ø)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7516/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.92% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/7516/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvc3FsTGFiLmpz) | `50% <0%> (-6.61%)` | :arrow_down: |
| [superset/assets/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/7516/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9mZWF0dXJlRmxhZ3MudHM=) | `90% <100%> (+1.11%)` | :arrow_up: |
| [superset/assets/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/7516/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvYWN0aW9ucy9zcWxMYWIuanM=) | `64.73% <13.04%> (-5.92%)` | :arrow_down: |
| [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7516/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `54.7% <20%> (-5.11%)` | :arrow_down: |
| [.../assets/src/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7516/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9BY2VFZGl0b3JXcmFwcGVyLmpzeA==) | `58.33% <71.42%> (+1.41%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7516?src=pr&el=footer). Last update [fda1002...a137550](https://codecov.io/gh/apache/incubator-superset/pull/7516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org