[jira] [Work logged] (HIVE-25822) Incorrect False positive result rows may be outputted in case outer join has conditions only affecting one side

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25822?focusedWorklogId=698488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-698488 ]

ASF GitHub Bot logged work on HIVE-25822:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Dec/21 07:55
            Start Date: 20/Dec/21 07:55
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on a change in pull request #2891:
URL: https://github.com/apache/hive/pull/2891#discussion_r772145536



##########
File path: ql/src/test/results/clientpositive/llap/join_1to1.q.out
##########
@@ -373,9 +373,6 @@ NULL	NULL	NULL	25	10025	66
 NULL	NULL	NULL	30	10030	88
 NULL	NULL	NULL	35	10035	88
 NULL	NULL	NULL	40	10040	88
-NULL	NULL	NULL	50	10050	66
-NULL	NULL	NULL	50	10050	66
-NULL	NULL	NULL	50	10050	88

Review comment:
       yes; overwrite without checking tends to happen - that's why I see no value in the tests which use the `src` table - which content is not defined at all - one way around these problems is to use `assert_true` ...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 698488)
    Time Spent: 0.5h  (was: 20m)

> Incorrect False positive result rows may be outputted in case outer join has conditions only affecting one side
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-25822
>                 URL: https://issues.apache.org/jira/browse/HIVE-25822
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> needed
> * outer join
> * on condition has at least one condition for one side of the join
> * in a single reducer:
> ** a right hand side only row outputted right before
> ** >=2 rows on LHS and 1 on RHS matching in the join keys but the first LHS doesn't satisfies the filter condition
> ** second LHS row with good filter condition
> {code}
> with
> t_y as (select col1 as id,col2 as s from (VALUES(0,'a'),(1,'y')) as c),
> t_xy as (select col1 as id,col2 as s from (VALUES(1,'x'),(1,'y')) as c) 
> select * from t_xy l full outer join t_y r on (l.id=r.id and l.s='y');
> {code}
> null,null,1,y is a false positive result
> {code}
> +-------+-------+-------+-------+
> | l.id  |  l.s  | r.id  |  r.s  |
> +-------+-------+-------+-------+
> | NULL  | NULL  | 0     | a     |
> | 1     | x     | NULL  | NULL  |
> | NULL  | NULL  | 1     | y     |
> | 1     | y     | 1     | y     |
> +-------+-------+-------+-------+
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)