You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/02/01 16:51:05 UTC
[GitHub] [spark] hvanhovell opened a new pull request, #39854: [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT
hvanhovell opened a new pull request, #39854:
URL: https://github.com/apache/spark/pull/39854
### What changes were proposed in this pull request?
This PR makes sure SBT assembles the connect server assembly jar before we run client tests.
### Why are the changes needed?
It makes it easier to develop and test the JVM client for Spark Connect.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manually tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39854: [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #39854:
URL: https://github.com/apache/spark/pull/39854#issuecomment-1413001585
Merged to master and branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #39854: [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #39854:
URL: https://github.com/apache/spark/pull/39854#issuecomment-1412387664
cc @zhenlineo @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39854: [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #39854:
URL: https://github.com/apache/spark/pull/39854#discussion_r1093504577
##########
project/SparkBuild.scala:
##########
@@ -851,6 +851,9 @@ object SparkConnectClient {
)
},
+ // Make sure the connect server assembly jar is available for testing.
+ test := ((Test / test) dependsOn (LocalProject("connect") / assembly)).value,
Review Comment:
> does maven have a similar solution？
Let me investigate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39854: [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #39854: [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT
URL: https://github.com/apache/spark/pull/39854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39854: [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #39854:
URL: https://github.com/apache/spark/pull/39854#discussion_r1093494467
##########
project/SparkBuild.scala:
##########
@@ -851,6 +851,9 @@ object SparkConnectClient {
)
},
+ // Make sure the connect server assembly jar is available for testing.
+ test := ((Test / test) dependsOn (LocalProject("connect") / assembly)).value,
Review Comment:
looks perfect, does maven have a similar solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org