You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/01 17:39:03 UTC

[GitHub] [pinot] walterddr opened a new issue #7673: Upgrade args4j to picocli

walterddr opened a new issue #7673:
URL: https://github.com/apache/pinot/issues/7673


   This issue is an extension from the previous discussion in #7591.
   
   Proposal
   ---
   Propose to use [picocli](https://github.com/remkop/picocli) for this mainly for several reasons:
   1. picocli has been a reliable and actively develop CLI project.
       - lack of development activity of args4j could potentially causes security vulnerability since no one is patching those upstream.
   2. the POC of the migration #7665 works quite well with all backward compatibility features enabled 
       - with one exception: `--forbid` was not implemented in the POC, but it should be easily supported via preprocessor.
   3. It will create better extensibility down the road, for example we can dynamically attach `SubCommand` to an existing command.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] walterddr commented on issue #7673: Upgrade args4j to picocli

Posted by GitBox <gi...@apache.org>.
walterddr commented on issue #7673:
URL: https://github.com/apache/pinot/issues/7673#issuecomment-963701902


   I think we can close this one @xiangfu0 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] xiangfu0 closed issue #7673: Upgrade args4j to picocli

Posted by GitBox <gi...@apache.org>.
xiangfu0 closed issue #7673:
URL: https://github.com/apache/pinot/issues/7673


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang closed issue #7673: Upgrade args4j to picocli

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang closed issue #7673:
URL: https://github.com/apache/pinot/issues/7673


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org