You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/28 05:31:21 UTC

[GitHub] [cloudstack] rhtyd commented on issue #3739: Add new command to update security group name

rhtyd commented on issue #3739: Add new command to update security group name
URL: https://github.com/apache/cloudstack/pull/3739#issuecomment-579087372
 
 
   @ravening few points:
   - Please follow and implement based more modern API implementation such as https://github.com/apache/cloudstack/blob/master/api/src/main/java/org/apache/cloudstack/api/command/admin/acl/UpdateRoleCmd.java#L34 (put version, use APINAME etc.)
   - Move the test to smoke instead of component if it's a fast enough test
   - Add the new marvin test to `.travis.yml` (sort alphabetically)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services