You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "nikita-ivanov-cc (via GitHub)" <gi...@apache.org> on 2025/08/04 21:58:54 UTC
[PR] Update README.md for end-to-end tests [flink]
nikita-ivanov-cc opened a new pull request, #26866:
URL: https://github.com/apache/flink/pull/26866
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follow [the conventions for tests defined in our code quality guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (/ no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (/ no)
- The serializers: (/ no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (/ no /)
- The S3 file system connector: (/ no / )
## Documentation
- Does this pull request introduce a new feature? (/ no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26866:
URL: https://github.com/apache/flink/pull/26866#issuecomment-4637808369
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26866:
URL: https://github.com/apache/flink/pull/26866#issuecomment-4395001523
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26866: Update README.md for end-to-end tests
URL: https://github.com/apache/flink/pull/26866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "nikita-ivanov-cc (via GitHub)" <gi...@apache.org>.
nikita-ivanov-cc commented on code in PR #26866:
URL: https://github.com/apache/flink/pull/26866#discussion_r2293683103
##########
flink-end-to-end-tests/README.md:
##########
@@ -5,6 +5,11 @@ This module contains tests that verify end-to-end behaviour of Flink.
The tests defined in `run-nightly-tests.sh` are run by the CI system on every pull request
and push to master.
+**Before running end-to-end tests, make sure you have built Flink and all modules using:**
+ ```
+ mvn clean install -Dfast -T 1C -DskipTests -Denforcer.skip=true
Review Comment:
some of e2e tests will fail, if you not run mvn install before it. it creates needed jars to use by the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "nikita-ivanov-cc (via GitHub)" <gi...@apache.org>.
nikita-ivanov-cc commented on code in PR #26866:
URL: https://github.com/apache/flink/pull/26866#discussion_r2293683103
##########
flink-end-to-end-tests/README.md:
##########
@@ -5,6 +5,11 @@ This module contains tests that verify end-to-end behaviour of Flink.
The tests defined in `run-nightly-tests.sh` are run by the CI system on every pull request
and push to master.
+**Before running end-to-end tests, make sure you have built Flink and all modules using:**
+ ```
+ mvn clean install -Dfast -T 1C -DskipTests -Denforcer.skip=true
Review Comment:
the e2e tests won't run if you not run mvn install before it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "nikita-ivanov-cc (via GitHub)" <gi...@apache.org>.
nikita-ivanov-cc commented on code in PR #26866:
URL: https://github.com/apache/flink/pull/26866#discussion_r2293688008
##########
flink-end-to-end-tests/README.md:
##########
@@ -5,6 +5,11 @@ This module contains tests that verify end-to-end behaviour of Flink.
The tests defined in `run-nightly-tests.sh` are run by the CI system on every pull request
and push to master.
+**Before running end-to-end tests, make sure you have built Flink and all modules using:**
Review Comment:
thank you , fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26866:
URL: https://github.com/apache/flink/pull/26866#issuecomment-3152531315
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff513e6560f727babbdd16612aab6acff91a196a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ff513e6560f727babbdd16612aab6acff91a196a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff513e6560f727babbdd16612aab6acff91a196a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #26866:
URL: https://github.com/apache/flink/pull/26866#discussion_r2344090073
##########
flink-end-to-end-tests/README.md:
##########
@@ -5,6 +5,11 @@ This module contains tests that verify end-to-end behaviour of Flink.
The tests defined in `run-nightly-tests.sh` are run by the CI system on every pull request
and push to master.
+**Before running end-to-end tests, make sure you have built Flink and all modules using:**
+ ```
+ mvn clean install -Dfast -T 1C -DskipTests -Denforcer.skip=true
Review Comment:
my question not `why do you run mvn install?`
my question is why do you suggest a different command instead the one already recommended in `building.md` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #26866:
URL: https://github.com/apache/flink/pull/26866#discussion_r2344090073
##########
flink-end-to-end-tests/README.md:
##########
@@ -5,6 +5,11 @@ This module contains tests that verify end-to-end behaviour of Flink.
The tests defined in `run-nightly-tests.sh` are run by the CI system on every pull request
and push to master.
+**Before running end-to-end tests, make sure you have built Flink and all modules using:**
+ ```
+ mvn clean install -Dfast -T 1C -DskipTests -Denforcer.skip=true
Review Comment:
my question not `why do you run mvn install?`
my question is why do you suggest a different command instead of the one already recommended in `building.md` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26866:
URL: https://github.com/apache/flink/pull/26866#discussion_r2273348232
##########
flink-end-to-end-tests/README.md:
##########
@@ -5,6 +5,11 @@ This module contains tests that verify end-to-end behaviour of Flink.
The tests defined in `run-nightly-tests.sh` are run by the CI system on every pull request
and push to master.
+**Before running end-to-end tests, make sure you have built Flink and all modules using:**
Review Comment:
I suggest it would read better if this new text is at the start of the Running Tests section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #26866:
URL: https://github.com/apache/flink/pull/26866#issuecomment-3184380637
@nikita-ivanov-cc Please could you follow [https://flink.apache.org/how-to-contribute/contribute-code/ ](https://flink.apache.org/how-to-contribute/contribute-code/ )and start the tile of the PR with either [Jira number] or [hotfix].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update README.md for end-to-end tests [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #26866:
URL: https://github.com/apache/flink/pull/26866#discussion_r2283279744
##########
flink-end-to-end-tests/README.md:
##########
@@ -5,6 +5,11 @@ This module contains tests that verify end-to-end behaviour of Flink.
The tests defined in `run-nightly-tests.sh` are run by the CI system on every pull request
and push to master.
+**Before running end-to-end tests, make sure you have built Flink and all modules using:**
+ ```
+ mvn clean install -Dfast -T 1C -DskipTests -Denforcer.skip=true
Review Comment:
what is the reason to run the command different from the one from here
https://github.com/apache/flink/blob/232920e4fd09dc9e26d9ddfbb962c00dfdd08535/docs/content/docs/flinkDev/building.md?plain=1#L63
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org