You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2017/06/27 10:28:00 UTC
[jira] [Updated] (HADOOP-14595) SwiftNativeFileSystem Internal
method has not been used
[ https://issues.apache.org/jira/browse/HADOOP-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-14595:
------------------------------------
Affects Version/s: 2.8.1
Summary: SwiftNativeFileSystem Internal method has not been used (was: Internal method has not been used, should be deleted or marked as unused)
Component/s: fs/swift
> SwiftNativeFileSystem Internal method has not been used
> -------------------------------------------------------
>
> Key: HADOOP-14595
> URL: https://issues.apache.org/jira/browse/HADOOP-14595
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/swift
> Affects Versions: 2.8.1
> Reporter: Yasen Liu
> Priority: Trivial
> Attachments: HADOOP-14595.001.patch
>
>
> i found the method is unused method,and is internal implementation.In order to keep the code clean,I think it should be deleted or marked as unused.
> /**
> * internal implementation of directory creation.
> *
> * @param path path to file
> * @return boolean file is created; false: no need to create
> * @throws IOException if specified path is file instead of directory
> */
> private boolean mkdir(Path path) throws IOException {
> Path directory = makeAbsolute(path);
> boolean shouldCreate = shouldCreate(directory);
> if (shouldCreate) {
> forceMkdir(directory);
> }
> return shouldCreate;
> }
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org