You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/02/21 22:05:09 UTC
[Impala-ASF-CR] IMPALA-6219: actually turn on AES-GCM
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9386
Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................
IMPALA-6219: actually turn on AES-GCM
There was a typo that prevented it from matching the output of cpuinfo
correctly.
Testing:
Manually verified that impalad.INFO contains the expected hardware
flags:
Hardware Supports:
ssse3
sse4_1
sse4_2
popcnt
avx
avx2
pclmulqdq
Added logging to verify that openssl-util-test and impala with
--disk_spill_encryption=true were going down the expected code path.
Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
---
M be/src/util/cpu-info.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/9386/1
--
To view, visit http://gerrit.cloudera.org:8080/9386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9386
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6219: actually turn on AES-GCM
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9386
to look at the new patch set (#2).
Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................
IMPALA-6219: actually turn on AES-GCM
There was a typo that prevented it from matching the output of cpuinfo
correctly.
Testing:
Manually verified that impalad.INFO contains the expected hardware
flags:
Hardware Supports:
ssse3
sse4_1
sse4_2
popcnt
avx
avx2
pclmulqdq
Added temporary logging to verify that openssl-util-test and impala with
--disk_spill_encryption=true were going down the expected code path.
Added permanent logging at startup to report the default mode.
Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
---
M be/src/common/init.cc
M be/src/util/cpu-info.cc
M be/src/util/openssl-util.cc
M be/src/util/openssl-util.h
4 files changed, 16 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/9386/2
--
To view, visit http://gerrit.cloudera.org:8080/9386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9386
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6219: actually turn on AES-GCM
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9386 )
Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1981/
--
To view, visit http://gerrit.cloudera.org:8080/9386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9386
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 03:39:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6219: actually turn on AES-GCM
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9386 )
Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9386/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9386/1//COMMIT_MSG@25
PS1, Line 25: Added logging to verify that openssl-util-test and impala with
> Can we add this logging permanently for future debugging? Would be good to
The logging I added originally was really verbose and not that helpful. I added a startup log message that reports the default mode, which should be sufficient.
--
To view, visit http://gerrit.cloudera.org:8080/9386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9386
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 01:50:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6219: actually turn on AES-GCM
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9386 )
Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9386
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 07:18:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6219: actually turn on AES-GCM
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9386 )
Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................
Patch Set 2: Code-Review+2
Thanks for adding the logging!
--
To view, visit http://gerrit.cloudera.org:8080/9386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9386
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 02:07:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6219: actually turn on AES-GCM
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9386 )
Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................
IMPALA-6219: actually turn on AES-GCM
There was a typo that prevented it from matching the output of cpuinfo
correctly.
Testing:
Manually verified that impalad.INFO contains the expected hardware
flags:
Hardware Supports:
ssse3
sse4_1
sse4_2
popcnt
avx
avx2
pclmulqdq
Added temporary logging to verify that openssl-util-test and impala with
--disk_spill_encryption=true were going down the expected code path.
Added permanent logging at startup to report the default mode.
Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Reviewed-on: http://gerrit.cloudera.org:8080/9386
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/common/init.cc
M be/src/util/cpu-info.cc
M be/src/util/openssl-util.cc
M be/src/util/openssl-util.h
4 files changed, 16 insertions(+), 14 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9386
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6219: actually turn on AES-GCM
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9386 )
Change subject: IMPALA-6219: actually turn on AES-GCM
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9386/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9386/1//COMMIT_MSG@25
PS1, Line 25: Added logging to verify that openssl-util-test and impala with
Can we add this logging permanently for future debugging? Would be good to know which algo is effective.
--
To view, visit http://gerrit.cloudera.org:8080/9386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64f23c493c6cc8d7e51ff45bbb305a71085e84c8
Gerrit-Change-Number: 9386
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 00:01:36 +0000
Gerrit-HasComments: Yes