You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Dave Revell (JIRA)" <ji...@apache.org> on 2012/06/20 22:43:42 UTC
[jira] [Created] (HBASE-6248) Jetty init may fail if directory name
contains "master"
Dave Revell created HBASE-6248:
----------------------------------
Summary: Jetty init may fail if directory name contains "master"
Key: HBASE-6248
URL: https://issues.apache.org/jira/browse/HBASE-6248
Project: HBase
Issue Type: Bug
Components: master
Affects Versions: 0.94.0
Reporter: Dave Revell
Assignee: Dave Revell
Priority: Minor
InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6248) Jetty init may fail if directory
name contains "master"
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397946#comment-13397946 ]
Zhihong Ted Yu commented on HBASE-6248:
---------------------------------------
{code}
+ } else {
+ return p;
+ }
{code}
The else statement is not needed.
Can you tell us the result of running test suite ? Hadoop QA didn't process your patch.
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Attachments: HBASE-6248-0.94.0-0.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-6248) Jetty init may fail if directory
name contains "master"
Posted by "Dave Revell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HBASE-6248 started by Dave Revell.
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Attachments: HBASE-6248-0.94.0-0.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6248) Jetty init may fail if directory name
contains "master"
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6248:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-6248-0.94.0-0.diff, HBASE-6248-0.94.0-1.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6248) Jetty init may fail if directory name
contains "master"
Posted by "Dave Revell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Revell updated HBASE-6248:
-------------------------------
Status: Patch Available (was: In Progress)
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Attachments: HBASE-6248-0.94.0-0.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6248) Jetty init may fail if directory name
contains "master"
Posted by "Dave Revell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Revell updated HBASE-6248:
-------------------------------
Attachment: HBASE-6248-0.94.0-1.diff
New patch ending in "-1" removes the "else" statement, per Zhihong's style feedback.
All tests pass when running on 0.94.0 except for org.apache.hadoop.hbase.coprocessor.TestClassLoading, but this also fails on vanilla 0.94.0 so it wasn't due to my patch.
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Attachments: HBASE-6248-0.94.0-0.diff, HBASE-6248-0.94.0-1.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6248) Jetty init may fail if directory
name contains "master"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398166#comment-13398166 ]
Hudson commented on HBASE-6248:
-------------------------------
Integrated in HBase-TRUNK #3053 (See [https://builds.apache.org/job/HBase-TRUNK/3053/])
HBASE-6248 Jetty init may fail if directory name contains "master" (Dave Revell) (Revision 1352395)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InfoServer.java
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-6248-0.94.0-0.diff, HBASE-6248-0.94.0-1.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6248) Jetty init may fail if directory
name contains "master"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400015#comment-13400015 ]
Hudson commented on HBASE-6248:
-------------------------------
Integrated in HBase-0.94-security #37 (See [https://builds.apache.org/job/HBase-0.94-security/37/])
HBASE-6248 Jetty init may fail if directory name contains "master" (Dave Revell) (Revision 1352394)
Result = SUCCESS
tedyu :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/InfoServer.java
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-6248-0.94.0-0.diff, HBASE-6248-0.94.0-1.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6248) Jetty init may fail if directory
name contains "master"
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398027#comment-13398027 ]
Elliott Clark commented on HBASE-6248:
--------------------------------------
Thanks for this. That part of the jetty init was pretty junky.
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Attachments: HBASE-6248-0.94.0-0.diff, HBASE-6248-0.94.0-1.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6248) Jetty init may fail if directory name
contains "master"
Posted by "Dave Revell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Revell updated HBASE-6248:
-------------------------------
Attachment: HBASE-6248-0.94.0-0.diff
Patch v1 attached
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Attachments: HBASE-6248-0.94.0-0.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6248) Jetty init may fail if directory
name contains "master"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398365#comment-13398365 ]
Hudson commented on HBASE-6248:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #62 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/62/])
HBASE-6248 Jetty init may fail if directory name contains "master" (Dave Revell) (Revision 1352395)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InfoServer.java
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-6248-0.94.0-0.diff, HBASE-6248-0.94.0-1.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6248) Jetty init may fail if directory name
contains "master"
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6248:
----------------------------------
Fix Version/s: 0.94.1
0.96.0
Hadoop Flags: Reviewed
Integrated to 0.94 and trunk.
Thanks for the patch, Dave.
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-6248-0.94.0-0.diff, HBASE-6248-0.94.0-1.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6248) Jetty init may fail if directory
name contains "master"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398174#comment-13398174 ]
Hudson commented on HBASE-6248:
-------------------------------
Integrated in HBase-0.94 #268 (See [https://builds.apache.org/job/HBase-0.94/268/])
HBASE-6248 Jetty init may fail if directory name contains "master" (Dave Revell) (Revision 1352394)
Result = FAILURE
tedyu :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/InfoServer.java
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-6248-0.94.0-0.diff, HBASE-6248-0.94.0-1.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-6248) Jetty init may fail if directory name
contains "master"
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl closed HBASE-6248.
--------------------------------
> Jetty init may fail if directory name contains "master"
> -------------------------------------------------------
>
> Key: HBASE-6248
> URL: https://issues.apache.org/jira/browse/HBASE-6248
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.94.0
> Reporter: Dave Revell
> Assignee: Dave Revell
> Priority: Minor
> Fix For: 0.94.1, 0.96.0
>
> Attachments: HBASE-6248-0.94.0-0.diff, HBASE-6248-0.94.0-1.diff
>
>
> InfoServer.getWebAppsPath() unsafely assumes that any instance of the string "master" in the full path to hbase-webapps can be truncated. This breaks in the case where hbase is installed in a directory such as "/my/hbasemaster/".
> The result is that Jetty initialization will fail since the master determines an incorrect path to hbase-webapps. The master still runs but the web UI returns 503.
> I have a patch for this problem that I'll upload soon.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira