You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "vinoyang (JIRA)" <ji...@apache.org> on 2018/10/11 03:00:00 UTC

[jira] [Commented] (FLINK-10527) Cleanup constant isNewMode in YarnTestBase

    [ https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645881#comment-16645881 ] 

vinoyang commented on FLINK-10527:
----------------------------------

cc [~till.rohrmann] and [~Tison]

> Cleanup constant isNewMode in YarnTestBase
> ------------------------------------------
>
>                 Key: FLINK-10527
>                 URL: https://issues.apache.org/jira/browse/FLINK-10527
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Major
>
> This seems to be a residual problem with FLINK-10396. It is set to true in that PR. Currently it has three usage scenarios:
> 1. assert, caused an error
> {code:java}
> assumeTrue("The new mode does not start TMs upfront.", !isNewMode);
> {code}
> 2. if (!isNewMode) the logic in the block would not have invoked, the if block can be removed
> 3. if (isNewMode) always been invoked, the if statement can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)