[GitHub] [maven-shade-plugin] tisonkun commented on a diff in pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #150:
URL: https://github.com/apache/maven-shade-plugin/pull/150#discussion_r962577433


##########
src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java:
##########
@@ -85,6 +85,49 @@ public void relocatedClasses() throws Exception {
             tempJar.delete();
         }
     }
+
+    @Test
+    public void mergeRelocatedFiles() throws Exception {
+        SimpleRelocator relocator =
+                new SimpleRelocator( "org.foo", "borg.foo", null, Arrays.asList( "org.foo.exclude.*" ) );
+        relocators.add( relocator );
+
+        String content = "org.foo.Service\norg.foo.exclude.OtherService\n";

Review Comment:
   Make sense. I just copy from the test above. Code refactoring can be another topic that I don't mess up one PR. But it's fair enough for new code :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org