You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 19:56:58 UTC

[GitHub] [airflow] Taragolis commented on a diff in pull request #26831: Replace `unittests` test cases by pure `pytest` [Wave-1]

Taragolis commented on code in PR #26831:
URL: https://github.com/apache/airflow/pull/26831#discussion_r985296674


##########
tests/core/test_stats.py:
##########
@@ -167,6 +166,7 @@ def test_does_send_stats_using_dogstatsd_with_tags(self):
         )
 
     def test_does_send_stats_using_dogstatsd_when_statsd_and_dogstatsd_both_on(self):
+        # ToDo: Figure out why it identical to test_does_send_stats_using_dogstatsd_when_dogstatsd_on
         self.dogstatsd.incr("empty_key")
         self.dogstatsd_client.increment.assert_called_once_with(
             metric='empty_key', sample_rate=1, tags=[], value=1

Review Comment:
   Just add todo to figure out later why implementation same as `test_does_send_stats_using_dogstatsd_when_dogstatsd_on`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org