You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "theirix (via GitHub)" <gi...@apache.org> on 2025/07/13 21:29:04 UTC
[PR] Support min/max aggregates for FixedSizeBinary type [datafusion]
theirix opened a new pull request, #16765:
URL: https://github.com/apache/datafusion/pull/16765
## Which issue does this PR close?
- Closes #16513
## Rationale for this change
This
```sql
CREATE TABLE binaries AS VALUES (X'000103', 1);
CREATE VIEW fixed_size_binary_views
AS SELECT arrow_cast(column1, 'FixedSizeBinary(3)') as value, column2 as id FROM binaries;
SELECT id, MIN(value) FROM fixed_size_binary_views GROUP BY id ORDER BY id;
```
led to `Min/Max accumulator not implemented for type FixedSizeBinary`
## What changes are included in this PR?
Extended function-aggregate implementation to support FixedSizeBinary using [new arrow-rs](https://github.com/apache/arrow-rs/issues/7674) `min_fixed_size_binary` function.
Also, removed a leftover `FileTypeExt` after a previous refactoring
## Are these changes tested?
- slt integration tests
- manual tests
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Support min/max aggregates for FixedSizeBinary type [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16765:
URL: https://github.com/apache/datafusion/pull/16765#issuecomment-3075342025
Thanks again @theirix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Support min/max aggregates for FixedSizeBinary type [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #16765:
URL: https://github.com/apache/datafusion/pull/16765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Support min/max aggregates for FixedSizeBinary type [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #16765:
URL: https://github.com/apache/datafusion/pull/16765#discussion_r2205613541
##########
datafusion/datasource/src/file_compression_type.rs:
##########
@@ -244,12 +244,6 @@ impl FileCompressionType {
}
}
-/// Trait for extending the functionality of the `FileType` enum.
Review Comment:
This change seems unrelated -- while it is a good change can you please make it a separate PR so we can consider it separately from the FixedSizeBinary min/max?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Support min/max aggregates for FixedSizeBinary type [datafusion]
Posted by "theirix (via GitHub)" <gi...@apache.org>.
theirix commented on code in PR #16765:
URL: https://github.com/apache/datafusion/pull/16765#discussion_r2205658566
##########
datafusion/datasource/src/file_compression_type.rs:
##########
@@ -244,12 +244,6 @@ impl FileCompressionType {
}
}
-/// Trait for extending the functionality of the `FileType` enum.
Review Comment:
I agree, removed this unrelated commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org