You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/05 20:19:56 UTC

[GitHub] [airflow] dimberman commented on a change in pull request #11784: Add pod_template_override to executor_config

dimberman commented on a change in pull request #11784:
URL: https://github.com/apache/airflow/pull/11784#discussion_r518340032



##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -505,6 +506,20 @@ def create_pod_id(dag_id: str, task_id: str) -> str:
     return safe_dag_id + safe_task_id
 
 
+def get_base_pod_from_template(pod_template_file: Optional[str], kube_config: Any) -> k8s.V1Pod:
+    """
+    Reads either the pod_template_file set in the executor_config or the base pod_template_file
+    set in the airflow.cfg to craft a "base pod" that will be used by the KubernetesExecutor
+    @param pod_template_file: absolute path to a pod_template_file.yaml or None
+    @param kube_config:
+    @return:

Review comment:
       @kaxil fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org