Re: [PR] IGNITE-26774 Use MessageSerializer for GridDhtAtomicUpdateRequest [ignite]

["wernerdv (via GitHub)" <gi...@apache.org>]

wernerdv commented on code in PR #12516:
URL: https://github.com/apache/ignite/pull/12516#discussion_r2685267512


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicUpdateRequest.java:
##########
@@ -49,77 +44,81 @@
 public class GridDhtAtomicUpdateRequest extends GridDhtAtomicAbstractUpdateRequest {
     /** Keys to update. */
     @GridToStringInclude
-    @GridDirectCollection(KeyCacheObject.class)
+    @Order(11)
     private List<KeyCacheObject> keys;
 
     /** Values to update. */
     @GridToStringInclude
-    @GridDirectCollection(CacheObject.class)
+    @Order(12)

Review Comment:
   We should not use abbreviated forms in method names.
   
   `@Order(value = 12, method = "values")`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org