Re: [PR] [SPARK-57337][SS][RTM][StreamingShuffle][Part3.5]Add streaming shuffle shared transport and error plumbing [spark]

["uros-b (via GitHub)" <gi...@apache.org>]

uros-b commented on code in PR #56387:
URL: https://github.com/apache/spark/pull/56387#discussion_r3444152789


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -1781,6 +1781,20 @@ package object config {
       .intConf
       .createWithDefault(8)
 
+  // ---------------------------------------------------------------------------
+  // Streaming shuffle writer configs
+  // ---------------------------------------------------------------------------
+
+  private[spark] val STREAMING_SHUFFLE_CHECKSUM_ENABLED =
+    ConfigBuilder("spark.shuffle.streaming.checksum.enabled")
+      .doc("Whether to append a CRC32C checksum to each streaming shuffle data buffer. " +
+        "When enabled, the writer computes the checksum and embeds it in the DataMessage header; " +
+        "the reader recomputes and compares. A mismatch fails the task, providing early " +
+        "detection of data corruption in transit.")
+      .version("4.0.0")

Review Comment:
   ```suggestion
         .version("4.3.0")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org