You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by straightflush <gi...@git.apache.org> on 2015/08/27 00:57:49 UTC
[GitHub] drill pull request: Support all encoded vector types for Hash Aggr...
GitHub user straightflush opened a pull request:
https://github.com/apache/drill/pull/136
Support all encoded vector types for Hash Aggregator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/straightflush/drill hashagg-sv2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #136
----
commit 578e3f61131534b03fa183e7d05b19d5ae4b6896
Author: Amit Hadke <am...@gmail.com>
Date: 2015-08-26T22:47:01Z
Support all encoded vectore types for Hash Aggragator.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3715 Support all encoded vector types fo...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/136#issuecomment-137164063
@amithadke, could you look at trying to write a test like this instead of checking in a large input file?
There is a session option to turn off hash aggregate, you should be able to just duplicate this test changing the session option. Be sure to change it back to the default value after your test as the session is currently shared across tests.
https://github.com/apache/drill/commit/97a63168e93a70c7ed88d2e801dd2ea2e5f1dd74#diff-91bfb8c9a26887fbe594262b6b872c98R295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3715 Support all encoded vector types fo...
Posted by amithadke <gi...@git.apache.org>.
Github user amithadke commented on the pull request:
https://github.com/apache/drill/pull/136#issuecomment-136476945
@mehant @jaltekruse Could you take a look at recent patch? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3715 Support all encoded vector types fo...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/136#issuecomment-137202183
I got that backwards, it looks like the existing test should be disabling hash aggregate and verifying that streaming agg is planned instead. To be very thorough you might want to include a plan check in your test, but hash based operations are currently the default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3715 Support all encoded vector types fo...
Posted by mehant <gi...@git.apache.org>.
Github user mehant commented on the pull request:
https://github.com/apache/drill/pull/136#issuecomment-135205449
There have been bugs in the handling of sv2 in the case where the first and second batch are filtered out. Could you add a test case for this? a similar test was added for streaming aggregate as part of DRILL-3069: https://github.com/apache/drill/commit/97a63168e93a70c7ed88d2e801dd2ea2e5f1dd74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: Support all encoded vector types for Hash Aggr...
Posted by straightflush <gi...@git.apache.org>.
Github user straightflush commented on the pull request:
https://github.com/apache/drill/pull/136#issuecomment-135200237
@StevenMPhillips @jaltekruse
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-3715 Support all encoded vector types fo...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/136#issuecomment-135203792
We should have a plan verification test to make sure that this change actually has the desired effect. This should be able to execute fine without your change as well, but the plan will have and unnecessary SelectionVectorRemover in it today. You can see examples of plan verification tests in /Users/jaltekruse/drill/exec/java-exec/src/test/java/org/apache/drill/TestCTASPartitionFilter.java and other subclasses of PlanTestBase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---