You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/24 12:49:28 UTC

[GitHub] [arrow] nealrichardson commented on a diff in pull request #13432: ARROW-16900: [R] Upgrade lintr

nealrichardson commented on code in PR #13432:
URL: https://github.com/apache/arrow/pull/13432#discussion_r906030027


##########
ci/docker/linux-apt-lint.dockerfile:
##########
@@ -56,20 +56,8 @@ COPY ci/etc/rprofile /arrow/ci/etc/
 RUN cat /arrow/ci/etc/rprofile >> $(R RHOME)/etc/Rprofile.site
 # Also ensure parallel compilation of C/C++ code
 RUN echo "MAKEFLAGS=-j$(R -s -e 'cat(parallel::detectCores())')" >> $(R RHOME)/etc/Renviron.site
-
-
-COPY ci/scripts/r_deps.sh /arrow/ci/scripts/
-COPY r/DESCRIPTION /arrow/r/
-# We need to install Arrow's dependencies in order for lintr's namespace searching to work.
-# This could be removed if lintr no longer loads the dependency namespaces (see issues/PRs below)

Review Comment:
   @jonkeane which of these issues was about dependency namespaces? I didn't look closely but none were obvious from the title.
   
   I removed arrow dependencies and tested locally, and lintr 3.0.0 seems to work fine, assuming it wasn't silently passing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org