You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/28 03:14:30 UTC
[GitHub] frankfliu commented on issue #13702: Add maven wrapper to scala
project.
frankfliu commented on issue #13702: Add maven wrapper to scala project.
URL: https://github.com/apache/incubator-mxnet/pull/13702#issuecomment-450280405
@marcoabreu
checkin maven wrapper or gradle wrapper is very common practice in most of modern java projects.
check in binary files are bad in general, which is not able diff while updating, and will increase git repo size rapidly. But It should be OK for tools since they are not part of source code and won't be updated frequently. And maven wrapper and gradle wrapper jar files are tiny.
You can find many apache project with maven wrapper checked in github:
Here is a link to apache log4j project: https://github.com/apache/logging-log4j2/tree/master/.mvn/wrapper
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services