[GitHub] [hadoop] jojochuang commented on a change in pull request #3019: HADOOP-17609. Make SM4 support optional for OpenSSL native code.

[GitBox <gi...@apache.org>]

jojochuang commented on a change in pull request #3019:
URL: https://github.com/apache/hadoop/pull/3019#discussion_r773721930



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/OpensslSm4CtrCryptoCodec.java
##########
@@ -41,6 +41,10 @@ public OpensslSm4CtrCryptoCodec() {
     if (loadingFailureReason != null) {
       throw new RuntimeException(loadingFailureReason);
     }
+
+    if (!OpensslCipher.isSupported(CipherSuite.SM4_CTR_NOPADDING)) {
+      throw new RuntimeException("Doesn't support SM4 CTR.");

Review comment:
       How about making the message "the openssl native library is built without SM4 CTR support"?
   
   the rest looks good to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org